From: Daniel Vacek <neelx@suse.com>
To: David Sterba <dsterba@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 0/5] Return value name unifications
Date: Mon, 23 Jun 2025 16:20:27 +0200 [thread overview]
Message-ID: <CAPjX3FccM-MK2Ohfa+_1jKAwmXtv+5oCSUuDgms69NxuoCazUQ@mail.gmail.com> (raw)
In-Reply-To: <cover.1750246061.git.dsterba@suse.com>
On Wed, 18 Jun 2025 at 13:29, David Sterba <dsterba@suse.com> wrote:
>
> Use 'ret' instead of 'error'.
>
> David Sterba (5):
> btrfs: rename error to ret in btrfs_may_delete()
> btrfs: rename error to ret in btrfs_mksubvol()
> btrfs: rename error to ret in btrfs_sysfs_add_fsid()
> btrfs: rename error to ret in btrfs_sysfs_add_mounted()
> btrfs: rename error to ret in device_list_add()
The series LGTM.
Reviewed-by: Daniel Vacek <neelx@suse.com>
> fs/btrfs/ioctl.c | 35 ++++++++++++++--------------
> fs/btrfs/sysfs.c | 57 +++++++++++++++++++++++-----------------------
> fs/btrfs/volumes.c | 10 ++++----
> 3 files changed, 50 insertions(+), 52 deletions(-)
>
> --
> 2.49.0
>
>
prev parent reply other threads:[~2025-06-23 14:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-18 11:29 [PATCH 0/5] Return value name unifications David Sterba
2025-06-18 11:29 ` [PATCH 1/5] btrfs: rename error to ret in btrfs_may_delete() David Sterba
2025-06-18 11:29 ` [PATCH 2/5] btrfs: rename error to ret in btrfs_mksubvol() David Sterba
2025-06-18 11:29 ` [PATCH 3/5] btrfs: rename error to ret in btrfs_sysfs_add_fsid() David Sterba
2025-06-18 11:29 ` [PATCH 4/5] btrfs: rename error to ret in btrfs_sysfs_add_mounted() David Sterba
2025-06-18 11:29 ` [PATCH 5/5] btrfs: rename error to ret in device_list_add() David Sterba
2025-06-23 14:20 ` Daniel Vacek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPjX3FccM-MK2Ohfa+_1jKAwmXtv+5oCSUuDgms69NxuoCazUQ@mail.gmail.com \
--to=neelx@suse.com \
--cc=dsterba@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).