Re: [PATCH 8/8] btrfs-progs: string-utils: do not escape space while printing

[Daniel Vacek <neelx@suse.com>]

On Fri, 17 Oct 2025 at 18:43, David Sterba <dsterba@suse.cz> wrote:
>
> On Wed, Oct 15, 2025 at 02:11:56PM +0200, Daniel Vacek wrote:
> > Space is a valid printable character in C. On the other hand
> > string "\ " in fact results in an unknown escape sequence.
>
> The space is escaped because the helper is used to print stream dump
> or tree dump where space is the separator, so this patch would break it.
> Unless there's another reason than esaped space is not valid in C then
> we can't do that.

The reason is fstests are parsing the output of dump-tree and failing
on any space in the encrypted filename. That's how I found the bug.
Namely it's the generic/582 checking the encrypted filenames, well the
btrfs part of the test as I implemented it. It's the
get_ciphertext_filename() function in common/encrypt. I went through
several iterations but I could not come up with any better solution.
Hints are welcome here.

Thinking about it again, this is also missing correctly escaping %
into %% which I mangled in fstests. I should have really done it here.