From: "Chris Mason" <clm@fb.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Nick Terrell <nickrterrell@gmail.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
<linux-crypto@vger.kernel.org>, <linux-btrfs@vger.kernel.org>,
<squashfs-devel@lists.sourceforge.net>,
<linux-f2fs-devel@lists.sourceforge.net>,
<linux-kernel@vger.kernel.org>, Kernel Team <Kernel-team@fb.com>,
Nick Terrell <terrelln@fb.com>, Petr Malat <oss@malat.biz>,
Johannes Weiner <jweiner@fb.com>, Niket Agarwal <niketa@fb.com>,
Yann Collet <cyan@fb.com>
Subject: Re: [PATCH 5/9] btrfs: zstd: Switch to the zstd-1.4.6 API
Date: Wed, 16 Sep 2020 10:20:52 -0400 [thread overview]
Message-ID: <CCDAB4AB-DE8D-4ADE-9221-02AE732CBAE2@fb.com> (raw)
In-Reply-To: <20200916084958.GC31608@infradead.org>
On 16 Sep 2020, at 4:49, Christoph Hellwig wrote:
> On Tue, Sep 15, 2020 at 08:42:59PM -0700, Nick Terrell wrote:
>> From: Nick Terrell <terrelln@fb.com>
>>
>> Move away from the compatibility wrapper to the zstd-1.4.6 API. This
>> code is functionally equivalent.
>
> Again, please use sensible names And no one gives a fuck if this bad
> API is "zstd-1.4.6" as the Linux kernel uses its own APIs, not some
> random mess from a badly written userspace package.
Hi Christoph,
It’s not completely clear what you’re asking for here. If the API
matches what’s in zstd-1.4.6, that seems like a reasonable way to
label it. That’s what the upstream is for this code.
I’m also not sure why we’re taking extra time to shit on the zstd
userspace package. Can we please be constructive or at least
actionable?
-chris
next prev parent reply other threads:[~2020-09-16 21:03 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 3:42 [PATCH 0/9] Update to zstd-1.4.6 Nick Terrell
2020-09-16 3:42 ` [PATCH 1/9] lib: zstd: Add zstd compatibility wrapper Nick Terrell
2020-09-16 8:48 ` Christoph Hellwig
2020-09-16 20:21 ` Nick Terrell
2020-09-16 3:42 ` [PATCH 2/9] lib: zstd: Add decompress_sources.h for decompress_unzstd Nick Terrell
2020-09-16 3:42 ` [PATCH 4/9] crypto: zstd: Switch to zstd-1.4.6 API Nick Terrell
2020-09-16 8:49 ` Christoph Hellwig
2020-09-16 3:42 ` [PATCH 5/9] btrfs: zstd: Switch to the " Nick Terrell
2020-09-16 8:49 ` Christoph Hellwig
2020-09-16 14:20 ` Chris Mason [this message]
2020-09-16 14:30 ` Christoph Hellwig
2020-09-16 14:43 ` Chris Mason
2020-09-16 14:46 ` Christoph Hellwig
2020-09-16 15:01 ` Chris Mason
2020-09-16 18:27 ` Eric Biggers
2020-09-16 19:18 ` Nick Terrell
2020-09-17 1:35 ` Rik van Riel
2020-09-17 10:04 ` Christoph Hellwig
2020-09-17 14:28 ` Chris Mason
2020-09-17 17:57 ` Nick Terrell
2020-09-16 3:43 ` [PATCH 6/9] f2fs: " Nick Terrell
2020-09-16 3:43 ` [PATCH 7/9] squashfs: " Nick Terrell
2020-09-16 3:43 ` [PATCH 8/9] lib: unzstd: " Nick Terrell
2020-09-16 3:43 ` [PATCH 9/9] lib: zstd: Remove zstd compatibility wrapper Nick Terrell
[not found] ` <20200916034307.2092020-4-nickrterrell@gmail.com>
2020-09-16 8:01 ` [PATCH 3/9] lib: zstd: Upgrade to latest upstream zstd version 1.4.6 kernel test robot
2020-09-16 20:53 ` Nick Terrell
2020-09-16 20:53 ` Nick Terrell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CCDAB4AB-DE8D-4ADE-9221-02AE732CBAE2@fb.com \
--to=clm@fb.com \
--cc=Kernel-team@fb.com \
--cc=cyan@fb.com \
--cc=hch@infradead.org \
--cc=herbert@gondor.apana.org.au \
--cc=jweiner@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=nickrterrell@gmail.com \
--cc=niketa@fb.com \
--cc=oss@malat.biz \
--cc=squashfs-devel@lists.sourceforge.net \
--cc=terrelln@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox