From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f169.google.com ([209.85.192.169]:39235 "EHLO mail-pd0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751312AbaBGESg convert rfc822-to-8bit (ORCPT ); Thu, 6 Feb 2014 23:18:36 -0500 Received: by mail-pd0-f169.google.com with SMTP id v10so2629390pde.28 for ; Thu, 06 Feb 2014 20:18:36 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 6.2 \(1499\)) Subject: Re: [PATCH v3] Btrfs: add regression test for running snapshot and send concurrently From: Wang Shilong In-Reply-To: <20140206224337.GB13647@dastard> Date: Fri, 7 Feb 2014 12:18:31 +0800 Cc: xfs@oss.sgi.com, linux-btrfs@vger.kernel.org, jbacik@fb.com Message-Id: References: <1391703008-2322-1-git-send-email-wangshilong1991@gmail.com> <20140206224337.GB13647@dastard> To: Dave Chinner Sender: linux-btrfs-owner@vger.kernel.org List-ID: Hi Dave, > On Fri, Feb 07, 2014 at 12:10:08AM +0800, Wang Shilong wrote: >> +$BTRFS_UTIL_PROG subvolume snapshot -r $SCRATCH_MNT \ >> + $SCRATCH_MNT/snap_1 >> $seqres.full 2>&1 >> + >> +do_snapshots & >> +snapshots_pid=$! >> + >> +$BTRFS_UTIL_PROG send $SCRATCH_MNT/snap_1 > /dev/null 2>&1 || echo "btrfs send failed" > > Let's stop this anti-pattern before it takes hold. > > If there's output from the send command it should be > filtered and captured in the golden image. Hence any deviation > caused by errors is automatically flagged as an error. > > That's the whole point of using golden images for capturing errors - > you don't need to capture return values from binaries and it > guarantees that users are informed about failures through error > messages. IOWs: > > $BTRFS_UTIL_PROG send $SCRATCH_MNT/snap_1 | _btrfs_send_filter > > is what you should be doing here. I knew what you mean here, in fact, i did this on purpose. for this test failure, btrfs-prog did not output failure information from the beginning. So to make older progs can also detect the test failure, i dropped into this way. Anyway, if you don't like this and think old btrfs-progs needn't consider this, i will update the patch.^_^ Thanks, Wang > Cheers, > > Dave. > -- > Dave Chinner > david@fromorbit.com