From: Naohiro Aota <Naohiro.Aota@wdc.com>
To: Johannes Thumshirn <jth@kernel.org>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Cc: David Sterba <dsterba@suse.com>,
Naohiro Aota <Naohiro.Aota@wdc.com>,
Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>,
Johannes Thumshirn <Johannes.Thumshirn@wdc.com>,
Yi Zhang <yi.zhang@redhat.com>
Subject: Re: [PATCH] btrfs: zoned: fix incorrect ASSERT in btrfs_zoned_reserve_data_reloc_bg
Date: Tue, 9 Sep 2025 04:40:54 +0000 [thread overview]
Message-ID: <DCNZROY8CV6U.2WZ7G51K4JTRN@wdc.com> (raw)
In-Reply-To: <20250905135443.188488-1-jth@kernel.org>
On Fri Sep 5, 2025 at 10:54 PM JST, Johannes Thumshirn wrote:
> From: Johannes Thumshirn <johannes.thumshirn@wdc.com>
>
> When moving a block-group to the dedicated data relocation space-info in
> btrfs_zoned_reserve_data_reloc_bg() it is ASSERT()ed that the newly
> created block-group for data relocation does not contain any zone_unusable
> bytes.
>
> But on disks with zone_capacity < zone_size, the difference between
> zone_size and zone_capacity is accounted as zone_unusable.
>
> Instead of ASSERT()ing that the block-group does not contain any
> zone_unusable bytes, remove them from the block-groups total size.
>
> Reported-by: Yi Zhang <yi.zhang@redhat.com>
> Link: https://lore.kernel.org/linux-block/CAHj4cs8-cS2E+-xQ-d2Bj6vMJZ+CwT_cbdWBTju4BV35LsvEYw@mail.gmail.com/
> Fixes: daa0fde322350 ("btrfs: zoned: fix data relocation block group reservation")
> Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Reviewed-by: Naohiro Aota <naohiro.aota@wdc.com>
next prev parent reply other threads:[~2025-09-09 4:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-05 13:54 [PATCH] btrfs: zoned: fix incorrect ASSERT in btrfs_zoned_reserve_data_reloc_bg Johannes Thumshirn
2025-09-09 4:40 ` Naohiro Aota [this message]
2025-09-09 8:35 ` Yi Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DCNZROY8CV6U.2WZ7G51K4JTRN@wdc.com \
--to=naohiro.aota@wdc.com \
--cc=Johannes.Thumshirn@wdc.com \
--cc=dsterba@suse.com \
--cc=jth@kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=shinichiro.kawasaki@wdc.com \
--cc=yi.zhang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox