[PATCH] btrfs: zoned: use local fs_info variable in btrfs_load_block_group_dup

[PATCH] btrfs: zoned: use local fs_info variable in btrfs_load_block_group_dup

[Johannes Thumshirn]

btrfs_load_block_group_dup() has a local pointer to fs_info, yet the
error prints dereference fs_info from the block_group.

Use local fs_info variable to make the code more uniform.

Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
---
 fs/btrfs/zoned.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/fs/btrfs/zoned.c b/fs/btrfs/zoned.c
index 1ad4147d8bae..f74bd9099d8a 100644
--- a/fs/btrfs/zoned.c
+++ b/fs/btrfs/zoned.c
@@ -1438,13 +1438,13 @@ static int btrfs_load_block_group_dup(struct btrfs_block_group *bg,
 	bg->zone_capacity = min_not_zero(zone_info[0].capacity, zone_info[1].capacity);
 
 	if (unlikely(zone_info[0].alloc_offset == WP_MISSING_DEV)) {
-		btrfs_err(bg->fs_info,
+		btrfs_err(fs_info,
 			  "zoned: cannot recover write pointer for zone %llu",
 			  zone_info[0].physical);
 		return -EIO;
 	}
 	if (unlikely(zone_info[1].alloc_offset == WP_MISSING_DEV)) {
-		btrfs_err(bg->fs_info,
+		btrfs_err(fs_info,
 			  "zoned: cannot recover write pointer for zone %llu",
 			  zone_info[1].physical);
 		return -EIO;
@@ -1465,7 +1465,7 @@ static int btrfs_load_block_group_dup(struct btrfs_block_group *bg,
 	}
 
 	if (unlikely(zone_info[0].alloc_offset != zone_info[1].alloc_offset)) {
-		btrfs_err(bg->fs_info,
+		btrfs_err(fs_info,
 			  "zoned: write pointer offset mismatch of zones in DUP profile");
 		return -EIO;
 	}
-- 
2.52.0

Re: [PATCH] btrfs: zoned: use local fs_info variable in btrfs_load_block_group_dup

[Daniel Vacek]

On Fri, 23 Jan 2026 at 09:19, Johannes Thumshirn
<johannes.thumshirn@wdc.com> wrote:
>
> btrfs_load_block_group_dup() has a local pointer to fs_info, yet the
> error prints dereference fs_info from the block_group.
>
> Use local fs_info variable to make the code more uniform.
>
> Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>

Reviewed-by: Daniel Vacek <neelx@suse.com>

> ---
>  fs/btrfs/zoned.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/fs/btrfs/zoned.c b/fs/btrfs/zoned.c
> index 1ad4147d8bae..f74bd9099d8a 100644
> --- a/fs/btrfs/zoned.c
> +++ b/fs/btrfs/zoned.c
> @@ -1438,13 +1438,13 @@ static int btrfs_load_block_group_dup(struct btrfs_block_group *bg,
>         bg->zone_capacity = min_not_zero(zone_info[0].capacity, zone_info[1].capacity);
>
>         if (unlikely(zone_info[0].alloc_offset == WP_MISSING_DEV)) {
> -               btrfs_err(bg->fs_info,
> +               btrfs_err(fs_info,
>                           "zoned: cannot recover write pointer for zone %llu",
>                           zone_info[0].physical);
>                 return -EIO;
>         }
>         if (unlikely(zone_info[1].alloc_offset == WP_MISSING_DEV)) {
> -               btrfs_err(bg->fs_info,
> +               btrfs_err(fs_info,
>                           "zoned: cannot recover write pointer for zone %llu",
>                           zone_info[1].physical);
>                 return -EIO;
> @@ -1465,7 +1465,7 @@ static int btrfs_load_block_group_dup(struct btrfs_block_group *bg,
>         }
>
>         if (unlikely(zone_info[0].alloc_offset != zone_info[1].alloc_offset)) {
> -               btrfs_err(bg->fs_info,
> +               btrfs_err(fs_info,
>                           "zoned: write pointer offset mismatch of zones in DUP profile");
>                 return -EIO;
>         }
> --
> 2.52.0
>
>

Re: [PATCH] btrfs: zoned: use local fs_info variable in btrfs_load_block_group_dup

[Qu Wenruo]

在 2026/1/23 18:44, Johannes Thumshirn 写道:
> btrfs_load_block_group_dup() has a local pointer to fs_info, yet the
> error prints dereference fs_info from the block_group.
> 
> Use local fs_info variable to make the code more uniform.
> 
> Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>

Reviewed-by: Qu Wenruo <wqu@suse.com>

Thanks,
Qu

> ---
>   fs/btrfs/zoned.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/btrfs/zoned.c b/fs/btrfs/zoned.c
> index 1ad4147d8bae..f74bd9099d8a 100644
> --- a/fs/btrfs/zoned.c
> +++ b/fs/btrfs/zoned.c
> @@ -1438,13 +1438,13 @@ static int btrfs_load_block_group_dup(struct btrfs_block_group *bg,
>   	bg->zone_capacity = min_not_zero(zone_info[0].capacity, zone_info[1].capacity);
>   
>   	if (unlikely(zone_info[0].alloc_offset == WP_MISSING_DEV)) {
> -		btrfs_err(bg->fs_info,
> +		btrfs_err(fs_info,
>   			  "zoned: cannot recover write pointer for zone %llu",
>   			  zone_info[0].physical);
>   		return -EIO;
>   	}
>   	if (unlikely(zone_info[1].alloc_offset == WP_MISSING_DEV)) {
> -		btrfs_err(bg->fs_info,
> +		btrfs_err(fs_info,
>   			  "zoned: cannot recover write pointer for zone %llu",
>   			  zone_info[1].physical);
>   		return -EIO;
> @@ -1465,7 +1465,7 @@ static int btrfs_load_block_group_dup(struct btrfs_block_group *bg,
>   	}
>   
>   	if (unlikely(zone_info[0].alloc_offset != zone_info[1].alloc_offset)) {
> -		btrfs_err(bg->fs_info,
> +		btrfs_err(fs_info,
>   			  "zoned: write pointer offset mismatch of zones in DUP profile");
>   		return -EIO;
>   	}

Re: [PATCH] btrfs: zoned: use local fs_info variable in btrfs_load_block_group_dup

[Naohiro Aota]

On Fri Jan 23, 2026 at 5:14 PM JST, Johannes Thumshirn wrote:
> btrfs_load_block_group_dup() has a local pointer to fs_info, yet the
> error prints dereference fs_info from the block_group.
>
> Use local fs_info variable to make the code more uniform.
>
> Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>

Looks good.

Reviewed-by: Naohiro Aota <naohiro.aota@wdc.com>