From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.128.45 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794964155; b=5UxJV1+AzHE8lwVbgVuf1cl+wdCeE1TKsuHu2rJUj8JXRmLAf9PsgCz8lHcnxiz3ru+O XFW/eENdP6s7thBZueZCkGI6SwOCakXzMZJJq+QZ8c0Xvz42kR20ljqvOzb6uyhI3M2us jZK6Dc3tIKR5KVN4HOBgufBtd8/mYVhPlfgIDlz9yVGIsN7W5hsjsEfrjytawhJ0b7yxx 0KlgR2m0raqtaYCXu0VAwf1spy3hIWpioeH/srM3xQUTyKxY2nPJp4Sft7mWrChm8MIVQ GHa/86sX7uPVmVAH3oFst3HovoTPeBZJD8ryNTwUiJMgJ4dBZI7k3xhuc5yeLgAuJsA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794964155; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Mime-Version:Content-Type:Date:Message-Id:Subject:From:To:Cc:X-Mailer: References:In-Reply-To; bh=PZ+3qJZoMU255+lkasu7qmvLXDM4HNJXEBMWPQ3TNF4=; b=DpdYAEJdrwNyqONHiqkuA0rprgdGSLYch7NSn9Mjh/dOn3eMINwcf/X2YQS3xUn1vg/V 3nFBD3ma6vHp7FFWsmF2n7BILKv80XgdiZLJaOOpLuRxg02Jym0Vdo/MOzh7rbWu+Hes3 6W1sUtZFsh9/AINvDTnnU19T4DP9VXn8Lo1/D/uK1eb+Y+XkRrAgP7jFgsyi5ZLb831EW 1ptK9qcruUXlyjxVlegiNLi5sERKBH01aHAOD9324rH9b5uPwpVkmPmhESbofzzsyoK/D 07jCgKdh0yg5Iwa5FWXAGer57crePJpTvAKLWFGLwUtUDvvbk1eLNzZZfR3+bEkOiLA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=VHAwCAgm; arc=none smtp.remote-ip=209.85.128.45 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9069D606A330 for ; Wed, 18 Nov 2026 01:09:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 9069D606A330 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=VHAwCAgm Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4bb6adaf0f1so4217125e9.0 for ; Tue, 17 Nov 2026 17:09:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794964153; x=1795568953; darn=vger.kernel.org; h=in-reply-to:references:cc:to:from:subject:message-id:date :content-type:mime-version:from:to:cc:subject:date:message-id :reply-to:content-type; bh=PZ+3qJZoMU255+lkasu7qmvLXDM4HNJXEBMWPQ3TNF4=; b=VHAwCAgmRb/DGKYR9+ms8Cf5qCi3Gd0oKLrclEBf59rwhhv6AicK3WbCXcEYRh1w/j TMeOENMtGAPul3mf5lYMHgFjNJZXDbiiHTTL2mbrYoQsOmyXjsOFJLM21gOrSmUQVi6V xWuvUmFk6jZ5GwhXghxHEC33NVY6qFgeJY6mLRkJuSH1XofE2oM6y5qhOper74Z6DOfg 1YDGnIxC27pkz7PmkdpPTqtR7hQhw3QW7YJ2pcCKk0F1kc6Io4WAl3z+02G3DFU0NE5i T1o+OR6jx8pAltoBpMCMU5pl9RosEDcMzv5mBY0yfqWhe+MQQ1d83BTZNl2aAy8fyDRk I1Zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794964153; x=1795568953; h=in-reply-to:references:cc:to:from:subject:message-id:date :content-type:mime-version:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=PZ+3qJZoMU255+lkasu7qmvLXDM4HNJXEBMWPQ3TNF4=; b=xbIxkot5Y6Bcp69Sf+cYjCuMy3VqHaEZwDKaN+dlDn5Zesfd0hKp3CtooryemZ3S6v jn166wuiIifYsFf80onyv8rmfVyDfzPw2IbVrXFqu9D33P2iZmm14Q2Mu9Yaov4m6nDw 1f6aFHVbjq9ryUNfgYRAV8t8h6mvNqvlNvNZ24SQrbFSWIQaBb181zKERjtHtF0Co9EZ bQcUsDpSGYR45PdnGasUxvUY5VhJM4TQi8hhuOFtLuhcnnaYHhC+8S+4OCmsMxYuDC46 iEHOT7pdyoQjjUZR8MoGl4l1DnBfrjWGjmyCgPeWcDLWvWyW3PdbPEKsW8Xpv8Qd054U bKgA== X-Forwarded-Encrypted: i=1; AL+hErEux4vrAaNfKzV8ipKkm48Yd855o3G+NQS4G5KZQ34c3TttGhelog3RaOGQHGKSLH2LBqHm72I/4wyf0w==@vger.kernel.org X-Gm-Message-State: APuU4Z+gEwYpRx603A+HTQgR1UmKVrygVhu1Oi8YPLlVYWxjuP8kwX+e f4RoFpxNLX+b36bIf/2Fs1KWPdwIDfni8za9izqS7bezDe4f4aQfDM9j X-Gm-Gg: AYBFou2Dut/eSY2pegIA8TzvQTSPlA1Qsbfimy8iQA3CscFpM9fKOgasgxqMJJKOV3d K24fbsM8GvNtYUwggp1/M50fHraE3HaPsm29azpC9AT1ZKfPo+LcxHlTdrRx/HGyaIwhL/He3a3 EIrtuWjM1xkJ/FvVglgF4pwkna/AiofZg2HE/vs6MK5JHTZrmez08/2QaUiXpGHmdZyfXi+SYBm jRplYOk0kLM/3ioSaJyKten9rAfj6U17GW3LfSCpsOfq668J9OrN+ewtLQbKPRQ2GdgSxDHBxxw ypyaQ5/7yK4iN9koF+0HAugkZhQhfajXhYjjRxlhHcj+zgMT0oLD/NNk54HGMDWK/1RUJd1SeJM FXdkg5zm2buc2HIbwA52ByPf99KaE9wHy1XA39L2BDSFUgFGFQdw+hc8HqElq4G1W42Qj7+cbvH ymVKKoZ7lmYUGQqCXQUn0huXBHQCXVDtCtbmXtmu//CYA+7G727nTfRnBm+hRi8dIrUW3dnpHm7 mfBitdMEbxeSQ702mwJHUd5m4GZAugEloBwaUQv+BnAYdH0ScHI2O4VcFdpFO3dE8vD10rItcOs 7LnLH9MmiJbELVwe75qzf1miiQ== X-Received: by 2002:a05:600c:474c:b0:4bb:6a2d:b426 with SMTP id 5b1f17b1804b1-4bb7d5d40fdmr17867305e9.1.1794964152741; Tue, 17 Nov 2026 17:09:12 -0800 (PST) Received: from localhost ([2001:b07:5d26:7a6a:365a:60ff:fe0d:cfc6]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4bb7d256f64sm23087625e9.1.2026.11.17.17.09.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Nov 2026 17:09:11 -0800 (PST) X-Mailing-List: linux-btrfs@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 Content-Type: multipart/signed; boundary=b1a8dff5fd09ce748c6816739f5ee431ea78e5cf3134c99d90e2f9bc2bde; micalg=pgp-sha512; protocol="application/pgp-signature" Date: Wed, 18 Nov 2026 02:09:06 +0100 Message-Id: Subject: Re: [RFC PATCH v4 00/10] add provenance time (ptime) From: "koraynilay" To: "Jeff Layton" , "koraynilay" , "David Sterba" , "Namjae Jeon" , "Sungjong Seo" , "Alexander Viro" , "Christian Brauner" , "Trond Myklebust" , "Anna Schumaker" , "Chuck Lever" , "Konstantin Komarov" , "Paulo Alcantara" Cc: "Chris Mason" , "Yuezhang Mo" , "Jan Kara" , "NeilBrown" , "Olga Kornievskaia" , "Dai Ngo" , "Tom Talpey" , "Ronnie Sahlberg" , "Shyam Prasad N" , "Bharath SM" , "Sergey Senozhatsky" , "ChenXiaoSong" , "Darrick J . Wong" , "Sean Smith" , "Andrey Albershteyn" , "Pedro Falcato" , "Amir Goldstein" , =?utf-8?q?Pali_Roh=C3=A1r?= , , , , , , , , X-Mailer: aerc 0.22.0-0-gc2f86b7abde3 References: <20261115180343.576773-1-koray.fra@gmail.com> In-Reply-To: --b1a8dff5fd09ce748c6816739f5ee431ea78e5cf3134c99d90e2f9bc2bde Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Hello and thanks for replying, On Wed Nov 18, 2026 at 12:53 AM CET, Jeff Layton wrote: > On Sun, 2026-11-15 at 19:03 +0100, koraynilay wrote: >> This is an initial implementation of a new timestamp to indicate the >> time when a file/directory was initially created. >>=20 >> This patch series takes inspiration from the one by Sean Smith >> [1], but using >> file_setattr()/file_getattr() as suggested by Darrick J. Wong >> in [2]. >>=20 >> The semantics of this new timestamp should be at least these: >> - it should be the same as btime on a newly created file >> - it's user-settable, so it can be preserved for backups, filesystem >> conversions, archives and any similar operation >> - it should be preserved every time mtime gets preserved >>=20 >> and the correspondence with the other timestamps is as follows: >>=20 >> ctime <-> btime >> mtime <-> ptime >>=20 > > I'm not sure how to interpret the correspondence above. |-----\_-----------------|-----------| | \_ change/ | birth/ | | \_ modification| creation | | \------------|-----------| | inode time | ctime | btime | |------------|-----------|-----------| | file time | mtime | ptime | |------------|-----------|-----------| =20 ("file" as in "the concept of this file", I'd say "file content" but that would be incorrect for symlinks) so ctime is "inode change time", btime is "inode birth/creation time", while mtime is "file content change/modification time" and ptime would be "file content creation time" (same as Window's or MacOS's creation time). Does this make more sense? > >> Examples: >> 1) a .zsh_history file created in 2019, then after a few years the user >> decides to switch to another filesystem, copying the .zsh_history to >> the new home, in that case btime would have the timestamp of the copy >> and ptime would have the 2019 timestamp (just like mtime would have >> been preserved) >> 2) a symlink created in 2020 from the home directory to a /path going >> through the same process as the .zsh_history, in this case it would >> also make sense to sync the ptime to the 2020 timestamp instead of >> keeping only the btime (so the inode creation time). >>=20 >> The proof-of-concept code (for testing) for stat(1) and cp(1) is >> available at https://github.com/koraynilay/coreutils (master branch) >> (Note: these coreutils code changes are a prototype and won't be >> submitted upstream as-is, but they work as expected in simple stat and >> cp -a/--preserve=3Dptime tests) >>=20 >> Lastly, the name "provenance" and "ptime" are not final, I personally >> don't have a strong opinion on any name, but while testing with stat(1) >> I noticed that "Provenance" is definitely too long for the normal >> output, so another option which would fit well is "Origin time", >> abbreviated as "ntime" (OrigiN time) and not as "otime", as that would >> conflict with btrfs' internal naming and create confusion. >>=20 >> v2 changes: >> - fix permission bypass leading to ptime update on immutable and >> append-only files (found by sashiko[3]) >> - normalize ptime timestamp as done in fs/attr.c:notify_change() (found >> by sashiko[3]) >> - fix wording in vfs patch to be like the cover-letter >>=20 >> v3 changes: >> - vfs: reject setting ptime with -EOPNOTSUPP on filesystems that do not >> support it instead of silently ignoring it (found by sashiko[4]) >> - vfs: fix not being able to clear immutable and append-only on files >> with ptime, and allow updating immutable/append-only atomically along >> with ptime (found by sashiko[4]) >> - btrfs: validate on-disk ptime nanoseconds and reset to otime if >> invalid (found by sashiko[4]) >> - btrfs: avoid re-assigning ptime on unrelated chattr calls (found by >> sashiko[4]) >> - add ntfs3 and exfat support as suggested by Amir Goldstein[5], but no >> vfat, smb, or nfs4 yet as they are a bit more complex >> - move the introduction of fileattr_has_fsx_mask() from the btrfs patch >> to a standalone patch in the series >> - btrfs: add fileattr_[gs]et to symlink and special file operations >>=20 >> v4 changes: >> - vfs: implement fsx_xflags_mask as suggested by Amir Goldstein[6]; >> - add SMB (ksmbd/cifs) and nfs (nfsd/nfs) support as requested in >> previous threads; >>=20 >> Note: >> to apply this patch 2 previous patches[7][8] from the ksmbd/cifs >> subsystem are needed. >>=20 >> New Question: >> should I rename fileattr_has_fsx_mask() to something like >> fileattr_has_unsupported_fsx() and keep its code as-is, or should I add >> the fsx_xflags_mask & ~allowed check in it and keep the name as-is? (or >> both?) >>=20 >> Thanks. >>=20 >> [1]: https://lore.kernel.org/20260405195007.1306-2-DefendTheDisabled@gma= il.com >> [2]: https://lore.kernel.org/20260407014129.GC6192@frogsfrogsfrogs >> [3]: https://sashiko.dev/#/patchset/20261027220532.736352-1-koray.fra%40= gmail.com >> [4]: https://sashiko.dev/#/patchset/20261028134728.294127-1-koray.fra%40= gmail.com >> [5]: https://lore.kernel.org/CAOQ4uxiuy0VwZj+3M-zRqQ49WTpHZpiaQ+6MZ8z8Wd= LjyQM_zA@mail.gmail.com/ >> [6]: https://lore.kernel.org/CAOQ4uxjtuTDT63vJdYaq+RHQEQFLTksp66e46OMN99= WhJz3SbA@mail.gmail.com/ >> [7]: https://lore.kernel.org/linux-cifs/20261112111637.184045-2-koray.fr= a@gmail.com/ >> [8]: https://lore.kernel.org/linux-cifs/20261115155308.415734-1-koray.fr= a@gmail.com/ >>=20 >>=20 >> koraynilay (10): >> vfs: add provenance time (ptime) >> vfs: add fileattr_has_fsx_mask() >> ntfs3: make crtime user-settable using ptime >> exfat: make crtime user-settable using ptime >> btrfs: add provenance time (ptime) >> vfs: add __vfs_fileattr_set_locked() for inode_lock()'d callers >> nfsd: add provenance time (ptime) via FATTR4_TIME_CREATE >> nfs: add provenance time (ptime) via FATTR4_TIME_CREATE >> ksmbd: add provenance time (ptime) and map it to CreationTime >> cifs: add provenance time (ptime) and map it to SMB's CreationTime >>=20 >> fs/btrfs/btrfs_inode.h | 4 + >> fs/btrfs/delayed-inode.c | 6 ++ >> fs/btrfs/inode.c | 29 +++++- >> fs/btrfs/ioctl.c | 24 ++++- >> fs/btrfs/print-tree.c | 1 + >> fs/btrfs/tree-log.c | 3 + >> fs/exfat/exfat_fs.h | 2 + >> fs/exfat/file.c | 42 ++++++++- >> fs/exfat/namei.c | 1 + >> fs/file_attr.c | 156 ++++++++++++++++++++++++++------ >> fs/nfs/inode.c | 27 +++++- >> fs/nfs/internal.h | 2 + >> fs/nfs/nfs4proc.c | 56 +++++++++++- >> fs/nfs/nfs4xdr.c | 19 ++-- >> fs/nfs/symlink.c | 1 + >> fs/nfsd/nfs4proc.c | 9 ++ >> fs/nfsd/nfs4xdr.c | 40 +++++--- >> fs/nfsd/vfs.c | 17 ++++ >> fs/nfsd/vfs.h | 4 +- >> fs/nfsd/xdr4.h | 3 + >> fs/ntfs3/file.c | 20 +++- >> fs/ntfs3/frecord.c | 8 +- >> fs/smb/client/cifsfs.c | 8 ++ >> fs/smb/client/inode.c | 7 +- >> fs/smb/client/ioctl.c | 109 ++++++++++++++++------ >> fs/smb/server/smb2pdu.c | 37 +++++--- >> fs/smb/server/vfs.c | 43 ++++++++- >> fs/smb/server/vfs.h | 1 + >> fs/stat.c | 2 + >> include/linux/fileattr.h | 29 +++++- >> include/linux/nfs_xdr.h | 3 + >> include/linux/stat.h | 1 + >> include/uapi/linux/btrfs_tree.h | 3 +- >> include/uapi/linux/fs.h | 9 +- >> include/uapi/linux/stat.h | 7 +- >> 35 files changed, 614 insertions(+), 119 deletions(-) >>=20 >>=20 >> base-commit: 3bc1fb9c3b20cd478c83496ab16addecb401770d >> prerequisite-patch-id: 049ae0eba275b5be35a238833107e0b251a55aa2 >> prerequisite-patch-id: 614f0bc9411391403d4e9702bafeb31b0ec04ec1 >> prerequisite-patch-id: ddf636b9d33d82ea206ce265d817371350bf8858 > > I think this is going to be very hard to do properly, because the > kernel can't really manage this on its own. Something in userland is > going to have to set this value if you want to update it to something > other than the original inode instantiation time (aka btime). > > It really sounds like what you want is the ability to make the btime > settable. Personally I think the decision to forbid that was wrong- > headed and that it should have been settable from userland from the > beginning. Maybe we should just revisit that decision. Originally I just wanted to have btime settable, yes, and if btime was settable I wouldn't have made this RFC PATCH either, but after reading the already existing discussions about it, I can understand having an "immutable inode creation time", like ctime exists, so even after making btime settable, a new timestamp would be necessary anyway (e.g. for the people who want btime to exist as a forensics timestamp). > Failing that, why not just track this in an xattr of some sort, since > this is really just an opaque blob once you allow it to be settable. If > the xattr isn't present, then you can just use the value of the btime > as-is. FWIW, I think samba does this today, so you could try to sync > with its behavior here. (This is copied and adapted from [2]) I actually have been using fully userspace xattrs[1] for a few months, mostly for backups, and it "works"; but last month I wanted to merge 2 FSs (and have another merge I have to do), so I ran [1] on all files and then compared all metadata/data between source and destination and noticed there were quite a lot of files that didn't have the xattr set. So I looked online and learned that xattrs only work on regular files/directories, not on symlinks or anything else (and the missing ones were of symlinks). This is what prompted me to search more if anyone had already proposed a new timestamp (instead of making btime settable) and found the email thread from april linked in the cover letter, which gave me the excuse to finally work on a proper patch. > That seems a lot simpler than adding an entirely new inode timestamp > that is always going to be a copy of the btime, except in rare cases. > Having to patch all of the on-disk filesystems with a new per-inode > field is a lot more work. > This patch is quite simple, but changing btrfs, then ext4, xfs, etc is a > mess, and inevitably you can't get these timestamps until you upgrade you= r > filesystems. So yeah while I do agree it touches a lot of code that could create problems, IMO this is the best solution and it would complete files' timestamps like other OSs have (and this, I think, is necessary for both backup/archival and migrations). Thanks, koraynilay [1]: https://github.com/koraynilay/btime-to-xattr [2]: https://lore.kernel.org/DMGS4KQLY24Q.14MUTR6U93GIC@gmail.com/ --b1a8dff5fd09ce748c6816739f5ee431ea78e5cf3134c99d90e2f9bc2bde Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQSgVimKafU5DQMcjcDmj22qf5IGXAUCavz6sgAKCRDmj22qf5IG XJc2AQDEw3DLWknN6hhurcFZrcIQwXM4vVkKq7ZARVMraoydvAEAstnUK3kjAUAY kVmRWWr3a9czwpWam0GcL2q7iV+QsgE= =OJC6 -----END PGP SIGNATURE----- --b1a8dff5fd09ce748c6816739f5ee431ea78e5cf3134c99d90e2f9bc2bde--