On Fri Nov 20, 2026 at 7:03 AM CET, Amir Goldstein wrote: > On Thu, Nov 19, 2026 at 11:25 PM koraynilay wrote: >> >> On Thu Nov 19, 2026 at 11:09 PM CET, Pali Rohár wrote: >> > On Thursday 19 November 2026 22:51:26 koraynilay wrote: >> >> On Thu Nov 19, 2026 at 6:34 PM CET, Amir Goldstein wrote: >> >> > On Sun, Nov 15, 2026 at 7:04 PM koraynilay wrote: >> >> >> >> >> >> Implement provenance time (ptime) in ksmbd, as introduced in a >> >> >> previous commit ("vfs: add provenance time (ptime)"). >> >> >> >> >> >> Map it to SMB's CreationTime, making it settable by SMB clients. When >> >> >> reporting CreationTime to clients, prioritize ptime over da.create_time >> >> >> memorized in the user.DOSATTRIB xattr. >> >> > >> >> > That doesn't sound like the right thing to do. >> >> > >> >> > If the server stored a CreationTime that client had set, you cannot >> >> > override this. >> >> >> >> Ah, yes, but how would we handle older files which get a custom >> >> CreationTime both before (in the xattr) and after (in ptime) a kernel >> >> upgrade? >> > >> > Just to note that this problem is already there. ksmbd can export for >> > example ntfs filesystem on removable disk. And this removable disk can >> > be connected to Windows machine which will always only touch >> > CreationTime and ignores xattr DOSATTRIB. >> > >> >> > When the client sets CreationTime, the server can decide if it can and wants >> >> > (may be a policy decision) to store CreationTime in PTIME and not store >> >> > it in user.DOSATTRIB. >> >> >> >> To fix the above problem we should probably keep storing it in both >> >> ptime and the xattr though. >> > >> > IMHO for a long term solution it is better to not have duplicated >> > information in xattr. Because duplicated information are going to be >> > out-of-sync. Windows NTFS driver will not update xattr DOSATTRIB. >> >> Yeah, to avoid out-of-sync issues is why I made ksmbd prefer ptime over >> the xattr's CreationTime. >> >> > >> > For me it looks like that this needs some policy / configuration >> > decision done by user. We do not know if the user will replug that disk >> > also to Windows NTFS driver (and then those xattr DOSATTRIB could cause >> > out-of-sync issues) or will only use it from Linux or Samba and then >> > xattr DOSATTRIB is probably fine. >> >> I'm not sure if this is the best solution, it doesn't feel too right >> to me, but maybe there isn't a better one. >> > > If you ask me, this is not your problem and I agree with Pali that > this is a policy decision. > > I would not include this patch at all in the series if I were you. > Maybe as a demo user, but you could just as well include a demo > user application. Ah, ok, fair. > The nfsd user is a simpler demo, so as long as the nfsd maintainers > are on the same page wrt the mutable btime plan, you could include > it in your series. > > The problem you raise with DOSATTRIB xattr is similar to the problems > that Chuck raised for ptime vs. btime as the source of FATTR4_TIME_CREATE Ah right, I can see the parallel, tho before the ptime change you couldn't modify the creation time at all from linux with nfsd, so in that case unless a user manually changed it after a kernel upgrade, it wouldn't have this desync problem (apart from a kernel downgrade). Thanks, koraynilay > Thanks, > Amir.