On Fri Nov 20, 2026 at 3:55 PM CET, Amir Goldstein wrote: > On Fri, Nov 20, 2026 at 2:34 PM koraynilay wrote: >> >> On Fri Nov 20, 2026 at 7:45 AM CET, Amir Goldstein wrote: >> > On Thu, Nov 19, 2026 at 11:10 PM koraynilay wrote: > >> >> > fa->fsx_xflags |= FS_XFLAG_CASENONPRESERVING; >> >> > + fa->fsx_xflags_mask |= FS_XFLAG_CASENONPRESERVING; >> >> > + fa->fsx_xflags_ro_mask |= FS_XFLAG_CASENONPRESERVING; >> >> Uhm, why both in _mask and _ro_mask? If it's a RDONLY flag shouldn't >> >> it *only* be in _ro_mask? (same for CASEFOLD) >> >> >> > >> > Good question. Maybe >> > I guess if you want to follow some percent >> > FS_FL_USER_MODIFIABLE is a subset of FS_FL_USER_VISIBLE >> > but I think that exporting ro_mask and _mask is going to be easier and >> > cleaner than rw_mask but not sure. >> >> Hmm I asked that also because you said in the xfs shared extent thread: >> >> > The advantage being that it makes the interface symmetric. >> > User can alway setattr() with the buffer they got from getattr() >> > and instead of randomly ignoring flags in set, the fsx_ro_mask >> > along with fsx_mask defines the behavior exactly. >> >> But by putting the ro flags in _mask too, a user would have to clean >> them out or vfs will reject the call with -EINVAL/something else, since >> in that case the vfs would see the user say "I want to change this [ro] >> flag". >> > > That's just a matter of interpretation. > > You could say that if flag FS_XFLAG_CASENONPRESERVING > is in ro_mask then its value may not be modified and fs needs to > fail the set Yes, that's what I was thinking. > if the user given value is not a match to the current > kernel's value. Since this is a new API, I think it's fine to -EINVAL if it's in _mask anyway, even if the value is the same, no? > Could be used for an "atomic flag set" operation, but I think > this is taking this too far. > > I am fine with xflags_ro_mask and xflags_rw_mask I guess this > is the less ambiguous option. Yeah I think this is the better approach here, I'll work using that. Thanks, koraynilay > Thanks, > Amir.