From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.218.52 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795188083; b=DeSO24P1tYV69hvx0WvXatPL5kTjQbY2hVOe0Zg/A37BYjBlK/CoPuFMPb6fw8UPrJ1u Hjz2GgQANPNL9OWafxT44xY/GsCDh8Y9SIY6nS7XpNM8cf44qFaGwV2dBZlJhtSV+SDDq ZaneR8KAxKa2DJuL/dXzE+0cwgWwfmXs2HR5EQjoWe/GL5X5JUBbxwxuMQ9rfR3cg2JSO JLb1AcyNUvM46zLzOtaBBBj7Vr26vV0/k4fVEUAACPLXhA7dBvSAV7JpMCUM2Z4xggpqh yXMXUY78wrcERI5Qj+XmPAbr/lLMH57/qws32rGPNXk3osRYc/P1bCT9GIKN/AN2MqA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795188083; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To:X-Mailer: References:In-Reply-To; bh=EOuNUplOgjccByi+i7DuzKPwQryobm9GZBpfnMCMmUY=; b=5rHWkskGzvwC5d6HUT2uj5gtIoMG7cKHHsALs6a6Fd0RFpKnzB0erHrxd8Unell3Spmy ej4jdZlGXJKlUcRmj2ieWzrxGS6OktkZfcypAzY0dbA+ffhepiaG1Bml0FT8DZdCeH0do fCmhimqirDYRXePCq9VcqMRM3QrjzVcrGOTFZGX6evMiOO3ZO4TXZCzoWODlgBv+BacrO NtcDyW7TF8CLomvnLoPI6/iWjBBPSPZjl72UO9EgUgVxkAHHyJSoPRmv8kBSH8LPNd0mu 4gZg4D5e/xj06YDdFdnb/kcCKuT2yXhFZE3DQWjtszO3OVlFRTD+5YJHlLzdSc3hIoA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=NS4+0sJS; arc=none smtp.remote-ip=209.85.218.52 Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CAF0A606A334 for ; Fri, 20 Nov 2026 15:21:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org CAF0A606A334 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=NS4+0sJS Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-c4d581da0aaso132767666b.2 for ; Fri, 20 Nov 2026 07:21:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1795188081; x=1795792881; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-type:mime-version:from:to:cc:subject:date:message-id :reply-to:content-type; bh=EOuNUplOgjccByi+i7DuzKPwQryobm9GZBpfnMCMmUY=; b=NS4+0sJSs9ZY/390/dC7VLJUTfAcS54lqeieQtRl8eH5yHWeiW5ytJUQmodv4DKhEJ Piyk+uvIFd6cA17v/LQ32rQmteQ4JvXR1QZozak/uFldjGBchuAxoES2PNfUGoBgDTv2 RbPBJZsdPY1/23IPeY0lzOgNMKQtBhaW79XKJ+OjgBo5KzxR2zORITcFzh48Lc61B/4G IpmH+hgmspro/l5uz2hxwnp5j764NrCPcIIHRgzCs3xPLWQwu9A3hyD4S+1gyNKuURVe ByXWj6Mlvb+BbN3iPRxqpawWP9jlY2TCk6M4RWxqsGJ9tZX/mW7dUMoA+Kuqk7L/DFfH KAPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795188081; x=1795792881; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-type:mime-version:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=EOuNUplOgjccByi+i7DuzKPwQryobm9GZBpfnMCMmUY=; b=MmdLxq0SgoN+SCUnMkziPuq1YQJlGZV29UsufaDcTnFmJ7rrWhS/7u1saCN9Skt3jN El9faYY3Kmzx3dYqUHnT1fhl4YL/emxzcjA8+7K8QjXYTsNHEUN7d0ylIZg9YEniIHMt CIyrk1jddx77qFD1cAAAoHODuxEXLJbHoPPEfNZ95msCMEmPrGjKhXIKd0RlgbWvhrL3 YUhKnHr+a+ZTAgSjrwnTI4MHf//GAmBsTsYxM/48AZy4O+U8ZAgVz98xOQ6QdoZiW6Ws pqY4C7r4zV3ClxrbuN16cE1gMzexPqx+WjLnW0hetbZ0Mngc1GtoRxo7R6JE1mfR8Y9+ mM6w== X-Forwarded-Encrypted: i=1; AL+hErG2psU8HGdnBMUlca986knLI/GlsFnfVEoLmKBwRaMpCn+Vc6HeWQMbkCUqNm1yqPwbQBzcGYJpBtnphA==@vger.kernel.org X-Gm-Message-State: APuU4Z//5r2VdwziTyXimlBi2E3UwvHS9mnOQGcSOl97sn/uQ31AifOy hRNMdg1kLgbaVZaNkLRc+LR6DlWFQ9rCLA5I7ZP8qn3hAy7oyvha07sn X-Gm-Gg: AZFdTZfR7exuW4yqKTA8jjyE7zrxj24n0xqkaSw4vHsQ2svsiArqKFqz+FmWdG/5eBj NPKtvcBlDkuimd+Nn/pDu4F4UxmWha4ugL4LyLNv6Ke6ry4jBqSSR2Y09bQyZr8eo2zhDuqS92p xapKwXHBN+I91cBAf8UV7Kh+TA2daQM7Rl5iLYpYCz5rtXK4+LXTdZelEd2hFgaSpwNf7ovn+CB NQLnlZtaIMNW+hzvJB2jLv7iGoQr9Djbee1avN8MZOb4Q/liQuLzvU/WgKxcLOcLmZGU49lTZcs WX+GaHNBgLczssHPdgP7gGYPqOySd/31xTIJR41SXBH2/AzONc0sRNam+rQCmXuDV+MoM1MYt0k Fv72JaF3AMHil+W28ZaU+ftkdnvdtB1/91KR6X/nNXRmU7ElUz99rSFmMKoNxQcEHobq57np9i/ /A2ophZJhuAhBEfZiEzL/WDSaabJlQD5sZCsap3AK7OmQziIAx1QWCtnN/GEKm6mHZgkaNZyO3M 8IbXAo6c9Wq6hp3Vi+BWdVhhwmpkyN6JNAoLFfnnUuZ/mPKHVV0WnB8gd33HjumOQxRJmDjkDXR oGNqSmUgdUPkE9HWRy4suRdLA0DLtis8lMLkiRAJXXMwCVKV X-Received: by 2002:a17:907:9903:b0:c49:cdc8:10cf with SMTP id a640c23a62f3a-c513ac754cbmr269557266b.40.1795188080773; Fri, 20 Nov 2026 07:21:20 -0800 (PST) Received: from localhost ([130.192.98.149]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4ab6c340df4sm7100009f8f.55.2026.11.20.07.21.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Nov 2026 07:21:19 -0800 (PST) X-Mailing-List: linux-btrfs@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 Content-Type: multipart/signed; boundary=f7e29ba536d1e92db179b4c7b2dcf417c13b9e676632060f29334f2a5d8b; micalg=pgp-sha512; protocol="application/pgp-signature" Date: Fri, 20 Nov 2026 16:21:11 +0100 Message-Id: Cc: "David Sterba" , "Namjae Jeon" , "Sungjong Seo" , "Alexander Viro" , "Christian Brauner" , "Trond Myklebust" , "Anna Schumaker" , "Chuck Lever" , "Jeff Layton" , "Konstantin Komarov" , "Paulo Alcantara" , "Chris Mason" , "Yuezhang Mo" , "Jan Kara" , "NeilBrown" , "Olga Kornievskaia" , "Dai Ngo" , "Tom Talpey" , "Ronnie Sahlberg" , "Shyam Prasad N" , "Bharath SM" , "Sergey Senozhatsky" , "ChenXiaoSong" , "Darrick J . Wong" , "Sean Smith" , "Andrey Albershteyn" , "Pedro Falcato" , =?utf-8?q?Pali_Roh=C3=A1r?= , , , , , , , , , "Theodore Tso" Subject: Re: [RFC PATCH v4 08/10] nfs: add provenance time (ptime) via FATTR4_TIME_CREATE From: "koraynilay" To: "Amir Goldstein" , "koraynilay" X-Mailer: aerc 0.22.0-0-gc2f86b7abde3 References: <20261115180343.576773-1-koray.fra@gmail.com> <20261115180343.576773-9-koray.fra@gmail.com> In-Reply-To: --f7e29ba536d1e92db179b4c7b2dcf417c13b9e676632060f29334f2a5d8b Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 On Fri Nov 20, 2026 at 3:55 PM CET, Amir Goldstein wrote: > On Fri, Nov 20, 2026 at 2:34=E2=80=AFPM koraynilay = wrote: >> >> On Fri Nov 20, 2026 at 7:45 AM CET, Amir Goldstein wrote: >> > On Thu, Nov 19, 2026 at 11:10=E2=80=AFPM koraynilay wrote: > >> >> > fa->fsx_xflags |=3D FS_XFLAG_CASENONPRESERVING; >> >> > + fa->fsx_xflags_mask |=3D FS_XFLAG_CASENONPRESERVI= NG; >> >> > + fa->fsx_xflags_ro_mask |=3D FS_XFLAG_CASENONPRESE= RVING; >> >> Uhm, why both in _mask and _ro_mask? If it's a RDONLY flag shouldn't >> >> it *only* be in _ro_mask? (same for CASEFOLD) >> >> >> > >> > Good question. Maybe >> > I guess if you want to follow some percent >> > FS_FL_USER_MODIFIABLE is a subset of FS_FL_USER_VISIBLE >> > but I think that exporting ro_mask and _mask is going to be easier and >> > cleaner than rw_mask but not sure. >> >> Hmm I asked that also because you said in the xfs shared extent thread: >> >> > The advantage being that it makes the interface symmetric. >> > User can alway setattr() with the buffer they got from getattr() >> > and instead of randomly ignoring flags in set, the fsx_ro_mask >> > along with fsx_mask defines the behavior exactly. >> >> But by putting the ro flags in _mask too, a user would have to clean >> them out or vfs will reject the call with -EINVAL/something else, since >> in that case the vfs would see the user say "I want to change this [ro] >> flag". >> > > That's just a matter of interpretation. > > You could say that if flag FS_XFLAG_CASENONPRESERVING > is in ro_mask then its value may not be modified and fs needs to > fail the set Yes, that's what I was thinking. > if the user given value is not a match to the current > kernel's value. Since this is a new API, I think it's fine to -EINVAL if it's in _mask anyway, even if the value is the same, no? > Could be used for an "atomic flag set" operation, but I think > this is taking this too far. > > I am fine with xflags_ro_mask and xflags_rw_mask I guess this > is the less ambiguous option. Yeah I think this is the better approach here, I'll work using that. Thanks, koraynilay > Thanks, > Amir. --f7e29ba536d1e92db179b4c7b2dcf417c13b9e676632060f29334f2a5d8b Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRJ2XvJtXGwULYEerQ0bnTtJTDoOAUCawBlZwAKCRA0bnTtJTDo ODe1AQCh/kbA9HU+8r+s0ju3A1YAvNO0gdrrV7t8u43sPfGVSwD5AdqpmBpPOV/5 L+Tc9hTqkeeZYhiO4l4Sy3W9VwznRwk= =IwFj -----END PGP SIGNATURE----- --f7e29ba536d1e92db179b4c7b2dcf417c13b9e676632060f29334f2a5d8b--