From mboxrd@z Thu Jan 1 00:00:00 1970 From: Theodore Tso Subject: Re: [PATCH 1/2] fs: add SEEK_HOLE and SEEK_DATA flags Date: Thu, 21 Apr 2011 16:45:54 -0400 Message-ID: References: <1303414954-3315-1-git-send-email-josef@redhat.com> Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii Cc: linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, hch@infradead.org To: Josef Bacik Return-path: In-Reply-To: <1303414954-3315-1-git-send-email-josef@redhat.com> List-ID: On Apr 21, 2011, at 3:42 PM, Josef Bacik wrote: > + case SEEK_DATA: > + case SEEK_HOLE: > + return -EINVAL; > } Maybe we should be returning EOPNOTSUPP? -- Ted