From: Christoph Hellwig <hch@infradead.org>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 2/2] btrfs: reduce div64 calls by limiting the number of stripes of a chunk to u32
Date: Sun, 5 Feb 2023 22:44:14 -0800 [thread overview]
Message-ID: <Y+ChvlcfOGHB7gd0@infradead.org> (raw)
In-Reply-To: <275da997c70615256bed3cff8e74ab2b3fecbafc.1675586554.git.wqu@suse.com>
> + if (unlikely(((u64)U32_MAX << BTRFS_STRIPE_LEN_SHIFT) <= length)) {
Nit, at least to me this order reads weird and I had to stop and think
a while. This version:
if (unlikely(length >= ((u64)U32_MAX << BTRFS_STRIPE_LEN_SHIFT))) {
would be more obvious.
> @@ -6344,7 +6345,7 @@ int btrfs_get_io_geometry(struct btrfs_fs_info *fs_info, struct extent_map *em,
>
> io_geom->len = len;
> io_geom->offset = offset;
> - io_geom->stripe_len = stripe_len;
> + io_geom->stripe_len = BTRFS_STRIPE_LEN;
This conflicts with the bio split series that has been in for-next
for a few weeks (but not in misc-next yet).
next prev parent reply other threads:[~2023-02-06 6:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-05 8:53 [PATCH 0/2] btrfs: reduce div64 calls for __btrfs_map_block() and its variants Qu Wenruo
2023-02-05 8:53 ` [PATCH 1/2] btrfs: remove map_lookup->stripe_len Qu Wenruo
2023-02-06 6:39 ` Christoph Hellwig
2023-02-06 8:28 ` Johannes Thumshirn
2023-02-06 8:50 ` Qu Wenruo
2023-02-06 8:56 ` Johannes Thumshirn
2023-02-05 8:53 ` [PATCH 2/2] btrfs: reduce div64 calls by limiting the number of stripes of a chunk to u32 Qu Wenruo
2023-02-05 12:09 ` kernel test robot
2023-02-05 12:20 ` kernel test robot
2023-02-06 6:44 ` Christoph Hellwig [this message]
2023-02-06 10:16 ` Qu Wenruo
2023-02-06 6:38 ` [PATCH 0/2] btrfs: reduce div64 calls for __btrfs_map_block() and its variants Christoph Hellwig
2023-02-06 6:58 ` Qu Wenruo
2023-02-06 7:02 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+ChvlcfOGHB7gd0@infradead.org \
--to=hch@infradead.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox