public inbox for linux-btrfs@vger.kernel.org
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org,
	linux-xfs@vger.kernel.org
Subject: Re: [PATCH 6/7] generic: add 251 to the auto group
Date: Thu, 9 Feb 2023 08:13:11 -0800	[thread overview]
Message-ID: <Y+Ublyc88P7mlg/i@magnolia> (raw)
In-Reply-To: <20230209051355.358942-7-hch@lst.de>

On Thu, Feb 09, 2023 at 06:13:54AM +0100, Christoph Hellwig wrote:
> generic/251 isn't dangerous, doesn't takes overly long to run and doesn't
> produce spurious failures, so add it to the auto group.

How long does it take for you?  It generally takes 300-700s to run on my
testing cloud.  That's not a reason to keep it out of the auto group,
but I've been surveying the long running tests to find the ones that run
stuff in a loop and subject them to TIME_FACTOR (or the new
SOAK_DURATION knob that I'm working on to allow direct control of loop
runtime) constraints.

--D

> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  tests/generic/251 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/generic/251 b/tests/generic/251
> index 192ab5cc..2a271cd1 100755
> --- a/tests/generic/251
> +++ b/tests/generic/251
> @@ -10,7 +10,7 @@
>  # corrupts the filesystem (data/metadata).
>  #
>  . ./common/preamble
> -_begin_fstest ioctl trim
> +_begin_fstest ioctl trim auto
>  
>  tmp=`mktemp -d`
>  trap "_cleanup; exit \$status" 0 1 3
> -- 
> 2.39.1
> 

  reply	other threads:[~2023-02-09 16:13 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-09  5:13 run more tests in the auto group Christoph Hellwig
2023-02-09  5:13 ` [PATCH 1/7] btrfs: add 198 and 219 to " Christoph Hellwig
2023-02-09  5:13 ` [PATCH 2/7] btrfs: add 125 to the auto and quick groups Christoph Hellwig
2023-02-09  5:13 ` [PATCH 3/7] btrfs: add 185 " Christoph Hellwig
2023-02-09  5:13 ` [PATCH 4/7] generic: add 042 " Christoph Hellwig
2023-02-09  5:13 ` [PATCH 5/7] generic: add 125 to the auto group Christoph Hellwig
2023-02-09  5:13 ` [PATCH 6/7] generic: add 251 " Christoph Hellwig
2023-02-09 16:13   ` Darrick J. Wong [this message]
2023-02-09 17:11     ` Christoph Hellwig
2023-02-09  5:13 ` [PATCH 7/7] xfs: add 080 to the auto and quick groups Christoph Hellwig
2023-02-09 14:40 ` run more tests in the auto group Zorro Lang
2023-02-09 16:13 ` Darrick J. Wong
2023-02-10 13:39 ` Anand Jain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y+Ublyc88P7mlg/i@magnolia \
    --to=djwong@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=hch@lst.de \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox