* [PATCH] btrfs: fix type of parameter generation in btrfs_get_dentry
@ 2022-10-18 14:05 David Sterba
2022-10-18 14:23 ` Josef Bacik
0 siblings, 1 reply; 2+ messages in thread
From: David Sterba @ 2022-10-18 14:05 UTC (permalink / raw)
To: linux-btrfs; +Cc: David Sterba, stable
The type of parameter generation has been u32 since the beginning,
however all callers pass a u64 generation, so unify the types to prevent
potential loss.
CC: stable@vger.kernel.org # 4.9+
Signed-off-by: David Sterba <dsterba@suse.com>
---
fs/btrfs/export.c | 2 +-
fs/btrfs/export.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/btrfs/export.c b/fs/btrfs/export.c
index 1d4c2397d0d6..fab7eb76e53b 100644
--- a/fs/btrfs/export.c
+++ b/fs/btrfs/export.c
@@ -58,7 +58,7 @@ static int btrfs_encode_fh(struct inode *inode, u32 *fh, int *max_len,
}
struct dentry *btrfs_get_dentry(struct super_block *sb, u64 objectid,
- u64 root_objectid, u32 generation,
+ u64 root_objectid, u64 generation,
int check_generation)
{
struct btrfs_fs_info *fs_info = btrfs_sb(sb);
diff --git a/fs/btrfs/export.h b/fs/btrfs/export.h
index f32f4113c976..5afb7ca42828 100644
--- a/fs/btrfs/export.h
+++ b/fs/btrfs/export.h
@@ -19,7 +19,7 @@ struct btrfs_fid {
} __attribute__ ((packed));
struct dentry *btrfs_get_dentry(struct super_block *sb, u64 objectid,
- u64 root_objectid, u32 generation,
+ u64 root_objectid, u64 generation,
int check_generation);
struct dentry *btrfs_get_parent(struct dentry *child);
--
2.37.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] btrfs: fix type of parameter generation in btrfs_get_dentry
2022-10-18 14:05 [PATCH] btrfs: fix type of parameter generation in btrfs_get_dentry David Sterba
@ 2022-10-18 14:23 ` Josef Bacik
0 siblings, 0 replies; 2+ messages in thread
From: Josef Bacik @ 2022-10-18 14:23 UTC (permalink / raw)
To: David Sterba; +Cc: linux-btrfs, stable
On Tue, Oct 18, 2022 at 04:05:52PM +0200, David Sterba wrote:
> The type of parameter generation has been u32 since the beginning,
> however all callers pass a u64 generation, so unify the types to prevent
> potential loss.
>
> CC: stable@vger.kernel.org # 4.9+
> Signed-off-by: David Sterba <dsterba@suse.com>
Reviewed-by: Josef Bacik <josef@toxicpanda.com>
Thanks,
Josef
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-18 14:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-18 14:05 [PATCH] btrfs: fix type of parameter generation in btrfs_get_dentry David Sterba
2022-10-18 14:23 ` Josef Bacik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).