From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64657C4332F for ; Tue, 11 Oct 2022 23:47:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229655AbiJKXq7 (ORCPT ); Tue, 11 Oct 2022 19:46:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33042 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229475AbiJKXq4 (ORCPT ); Tue, 11 Oct 2022 19:46:56 -0400 Received: from mail-pg1-x52a.google.com (mail-pg1-x52a.google.com [IPv6:2607:f8b0:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 766FB459B3 for ; Tue, 11 Oct 2022 16:46:53 -0700 (PDT) Received: by mail-pg1-x52a.google.com with SMTP id r18so14076030pgr.12 for ; Tue, 11 Oct 2022 16:46:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osandov-com.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=NXIZJTtVhqCpmyGjXMWK48RPmdnN8LgdLSZxMWzlW54=; b=VUROlRoYgzR70sQJFbpLvMSbh8bjmCg+iVdR7RSAsmc2GNvFxI/h4ESUYMGaloqv4Q O2zBYNVG+uyT7271G7zQNxrozKHUA+Tx6kZUdGKtLcddxNVFpHMIrU4ZQZLlv1LNzmXJ kGS4/EsrZ1wV18wXVjE3xThqiLKPUiPWTwBk5lbdzhfwrLp1Cs+L/gaRUtVL0cueFs/F ZX4sTamhLXAzfmNYbWFgQljACZ7/mn/+E5hysHFGLgE0NM7CpdXVZlOLl8SnZTZ8FuRT BghgxbWTKUJLUFAh2DEQqD1nJFvkll5hBCQ/nAYgV5yY+U+N87OhniNTIovWLG766DP3 7Ubw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=NXIZJTtVhqCpmyGjXMWK48RPmdnN8LgdLSZxMWzlW54=; b=Wu0EhIz9+Cco3clvx7HxGSd5zvsFceaHPH7PvGWESGiRdyrJgf3bR2DndtidJR5LKP g2U93pkrb9W1u9RaUZzwsR5AUi/YSN9tDXfdWg2oVfhIQ5h9rBw59imJ6UzOAEVa2mlQ 0/YejZiNrE29aCuZxLkVnpuTN0TjLqpjzsvYxcrSToBXwp5Xro8mTthVuHpwU2v0Gsq3 ldQ3ahnsvnRusCL8urZaXg8LlRmyY5DSyuHhfQwVACOZOyMJTsbAnJ33EoTAFJH264P3 3oKkBp5xwONoLECa+ADe4aqIr7kobVSGoLYdlGtZXHCeAIMoSfm7cVJCvhYfmhlpMlnt y2rQ== X-Gm-Message-State: ACrzQf2CkANhHqNsYRZk0oecT1uH6YB4Q+sE0XQr1pQQCNgNYP6n2nJ2 qGUfiNJ7VM/1VLcO7DFwOsR4lA== X-Google-Smtp-Source: AMsMyM5Ch+o6zNkMhMyXMxtlm7R5W1U/84gENt06G22RZbktX34GcbWPf0GyyDfHQ3unvKWyC4NbRw== X-Received: by 2002:a65:6b8e:0:b0:44f:ec0f:f684 with SMTP id d14-20020a656b8e000000b0044fec0ff684mr22336295pgw.25.1665532012852; Tue, 11 Oct 2022 16:46:52 -0700 (PDT) Received: from relinquished.localdomain ([2600:380:8047:f466:3e42:98bc:71a6:f1b7]) by smtp.gmail.com with ESMTPSA id r27-20020aa7963b000000b005636d8aa98dsm4543908pfg.141.2022.10.11.16.46.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Oct 2022 16:46:52 -0700 (PDT) Date: Tue, 11 Oct 2022 16:46:49 -0700 From: Omar Sandoval To: Sasha Levin Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Omar Sandoval , Filipe Manana , David Sterba , clm@fb.com, josef@toxicpanda.com, linux-btrfs@vger.kernel.org Subject: Re: [PATCH AUTOSEL 6.0 33/46] btrfs: get rid of block group caching progress logic Message-ID: References: <20221011145015.1622882-1-sashal@kernel.org> <20221011145015.1622882-33-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221011145015.1622882-33-sashal@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Tue, Oct 11, 2022 at 10:50:01AM -0400, Sasha Levin wrote: > From: Omar Sandoval > > [ Upstream commit 48ff70830bec1ccc714f4e31059df737f17ec909 ] > > struct btrfs_caching_ctl::progress and struct > btrfs_block_group::last_byte_to_unpin were previously needed to ensure > that unpin_extent_range() didn't return a range to the free space cache > before the caching thread had a chance to cache that range. However, the > commit "btrfs: fix space cache corruption and potential double > allocations" made it so that we always synchronously cache the block > group at the time that we pin the extent, so this machinery is no longer > necessary. > > Reviewed-by: Filipe Manana > Signed-off-by: Omar Sandoval > Signed-off-by: David Sterba > Signed-off-by: Sasha Levin > --- > fs/btrfs/block-group.c | 13 ------------ > fs/btrfs/block-group.h | 2 -- > fs/btrfs/extent-tree.c | 9 ++------- > fs/btrfs/free-space-tree.c | 8 -------- > fs/btrfs/transaction.c | 41 -------------------------------------- > fs/btrfs/zoned.c | 1 - > 6 files changed, 2 insertions(+), 72 deletions(-) Hi, Sasha, This commit is a cleanup. Please drop it from 6.0 and 5.19. Thanks, Omar