From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BFF0C433FE for ; Tue, 15 Nov 2022 20:46:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232049AbiKOUqP (ORCPT ); Tue, 15 Nov 2022 15:46:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52048 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232157AbiKOUqO (ORCPT ); Tue, 15 Nov 2022 15:46:14 -0500 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A87BB30F60 for ; Tue, 15 Nov 2022 12:46:13 -0800 (PST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id E1F3C3200903; Tue, 15 Nov 2022 15:46:12 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Tue, 15 Nov 2022 15:46:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bur.io; h=cc:cc :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1668545172; x=1668631572; bh=Og9fg9afYM rGM4KJ1gIxGfagnpWeM44ar1VTO9zuogY=; b=fFvt4xoMqUyTzV8qiv7lgV/z11 hz7RNiQqh4at/wP1L2KNArFA3y9mY8SKQUUxNTJMbYUQUI47O29BvA139/GUNWlj jslOezc1PzbaXWC+w9lm3wUEd4P28HIZMOz5qO/Bdgwx3mLF2VFsAE/+w5MRJ9z7 nsn8t6lhpoE/0MR9t7b24edK0/1PppDvwBmu1cAMdP6JXqGG79Imj8AVVKr6zzdv d6YCCmDC5WOtczJQDy8Jc5pMAfyQ6Mtdyb/BA1j+ZN8HkTOAKov4AiwA1cLRGmXI wZRSm7CPC06XKzfqQ5yAODSWkaRpZYCNij45gB7psFAzCiuNXXE/CMWyhcOg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1668545172; x=1668631572; bh=Og9fg9afYMrGM4KJ1gIxGfagnpWe M44ar1VTO9zuogY=; b=dBa3rw18iheid33uSvnN27iYahVhSS497Bm/7FFyuHZM AXogqGJrI49gfeyZz9vHmWMUkryf8snsoyFCl0xmBFQaD/8/iOEQ2qPahziTMPN7 nZmfeDno3qqOctGbMz3cJs/9HTxCjBPNDkKc0g5ULv309moWgbC3sFizKR7Nmpw2 B7HiZjRb291yMHMKZKwjoBiVD/fqSs13Eij1Gj5BjzmMf2t4OsdZn4e0ieT7S/uJ aPd1cbpN4xBZ5+4zudyAinzxc33O7LumkLrtPo8OE9R1+t/RYfUbL025vX6tmJ92 ygi1paw7CwhmEzVJ+P90BQBWlixVasy7JVmXtPedyA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrgeeggddugedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvvefukfhfgggtuggjsehttd ertddttddvnecuhfhrohhmpeeuohhrihhsuceuuhhrkhhovhcuoegsohhrihhssegsuhhr rdhioheqnecuggftrfgrthhtvghrnhepkedvkeffjeellefhveehvdejudfhjedthfdvve eiieeiudfguefgtdejgfefleejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghm pehmrghilhhfrhhomhepsghorhhishessghurhdrihho X-ME-Proxy: Feedback-ID: i083147f8:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 15 Nov 2022 15:46:11 -0500 (EST) Date: Tue, 15 Nov 2022 12:46:10 -0800 From: Boris Burkov To: fdmanana@kernel.org Cc: linux-btrfs@vger.kernel.org Subject: Re: [PATCH 2/3] btrfs-progs: receive: add debug messages when processing fallocate Message-ID: References: <7125ba99d511229e958daa14e385224e342b8a5c.1668529099.git.fdmanana@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7125ba99d511229e958daa14e385224e342b8a5c.1668529099.git.fdmanana@suse.com> Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Tue, Nov 15, 2022 at 04:25:25PM +0000, fdmanana@kernel.org wrote: > From: Filipe Manana > > Unlike for commands from the v1 stream, we have no debug messages logged > when processing fallocate commands, which makes it harder to debug issues. > > So add log messages, when the log verbosity level is >= 3, for fallocate > commands, mentioning the value of all fields. > > Signed-off-by: Filipe Manana Reviewed-by: Boris Burkov > --- > cmds/receive.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/cmds/receive.c b/cmds/receive.c > index b75a5634..e6f1aeab 100644 > --- a/cmds/receive.c > +++ b/cmds/receive.c > @@ -1296,6 +1296,11 @@ static int process_fallocate(const char *path, int mode, u64 offset, u64 len, > struct btrfs_receive *rctx = user; > char full_path[PATH_MAX]; > > + if (bconf.verbose >= 3) > + fprintf(stderr, > + "fallocate %s - offset=%llu, len=%llu, mode=%d\n", > + path, offset, len, mode); > + > ret = path_cat_out(full_path, rctx->full_subvol_path, path); > if (ret < 0) { > error("fallocate: path invalid: %s", path); > -- > 2.35.1 >