* [PATCH] fstests: skip btrfs/253 for zoned devices
@ 2022-11-28 12:29 Johannes Thumshirn
2022-11-28 16:02 ` Josef Bacik
2022-12-20 9:19 ` Johannes Thumshirn
0 siblings, 2 replies; 5+ messages in thread
From: Johannes Thumshirn @ 2022-11-28 12:29 UTC (permalink / raw)
To: Zorro Lang; +Cc: Johannes Thumshirn, linux-btrfs, fstests
The test-case btrfs/253 tests btrfs' chunk size setting, which is not
available on zoned btrfs, so the test will always fail.
Skip the test in case of a zoned device.
Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
---
tests/btrfs/253 | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/btrfs/253 b/tests/btrfs/253
index fbbb81fae754..99eaee1e7cde 100755
--- a/tests/btrfs/253
+++ b/tests/btrfs/253
@@ -81,6 +81,7 @@ alloc_size() {
_supported_fs btrfs
_require_test
_require_scratch
+_require_non_zoned_device "${SCRATCH_DEV}"
# Delete log file if it exists.
rm -f "${seqres}.full"
--
2.38.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] fstests: skip btrfs/253 for zoned devices
2022-11-28 12:29 [PATCH] fstests: skip btrfs/253 for zoned devices Johannes Thumshirn
@ 2022-11-28 16:02 ` Josef Bacik
2022-12-20 9:19 ` Johannes Thumshirn
1 sibling, 0 replies; 5+ messages in thread
From: Josef Bacik @ 2022-11-28 16:02 UTC (permalink / raw)
To: Johannes Thumshirn; +Cc: Zorro Lang, linux-btrfs, fstests
On Mon, Nov 28, 2022 at 04:29:52AM -0800, Johannes Thumshirn wrote:
> The test-case btrfs/253 tests btrfs' chunk size setting, which is not
> available on zoned btrfs, so the test will always fail.
>
> Skip the test in case of a zoned device.
>
> Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Reviewed-by: Josef Bacik <josef@toxicpanda.com>
Thanks,
Josef
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] fstests: skip btrfs/253 for zoned devices
2022-11-28 12:29 [PATCH] fstests: skip btrfs/253 for zoned devices Johannes Thumshirn
2022-11-28 16:02 ` Josef Bacik
@ 2022-12-20 9:19 ` Johannes Thumshirn
2022-12-20 10:13 ` Zorro Lang
1 sibling, 1 reply; 5+ messages in thread
From: Johannes Thumshirn @ 2022-12-20 9:19 UTC (permalink / raw)
To: Zorro Lang; +Cc: linux-btrfs@vger.kernel.org, fstests@vger.kernel.org
On 28.11.22 13:30, Johannes Thumshirn wrote:
> The test-case btrfs/253 tests btrfs' chunk size setting, which is not
> available on zoned btrfs, so the test will always fail.
>
> Skip the test in case of a zoned device.
>
> Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
> ---
> tests/btrfs/253 | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/btrfs/253 b/tests/btrfs/253
> index fbbb81fae754..99eaee1e7cde 100755
> --- a/tests/btrfs/253
> +++ b/tests/btrfs/253
> @@ -81,6 +81,7 @@ alloc_size() {
> _supported_fs btrfs
> _require_test
> _require_scratch
> +_require_non_zoned_device "${SCRATCH_DEV}"
>
> # Delete log file if it exists.
> rm -f "${seqres}.full"
Ping?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] fstests: skip btrfs/253 for zoned devices
2022-12-20 9:19 ` Johannes Thumshirn
@ 2022-12-20 10:13 ` Zorro Lang
2022-12-20 14:48 ` Johannes Thumshirn
0 siblings, 1 reply; 5+ messages in thread
From: Zorro Lang @ 2022-12-20 10:13 UTC (permalink / raw)
To: Johannes Thumshirn; +Cc: linux-btrfs@vger.kernel.org, fstests@vger.kernel.org
On Tue, Dec 20, 2022 at 09:19:06AM +0000, Johannes Thumshirn wrote:
> On 28.11.22 13:30, Johannes Thumshirn wrote:
> > The test-case btrfs/253 tests btrfs' chunk size setting, which is not
> > available on zoned btrfs, so the test will always fail.
> >
> > Skip the test in case of a zoned device.
> >
> > Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
> > ---
> > tests/btrfs/253 | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/tests/btrfs/253 b/tests/btrfs/253
> > index fbbb81fae754..99eaee1e7cde 100755
> > --- a/tests/btrfs/253
> > +++ b/tests/btrfs/253
> > @@ -81,6 +81,7 @@ alloc_size() {
> > _supported_fs btrfs
> > _require_test
> > _require_scratch
> > +_require_non_zoned_device "${SCRATCH_DEV}"
> >
> > # Delete log file if it exists.
> > rm -f "${seqres}.full"
>
> Ping?
Do I misunderstand something? I think this issue has been fixed long time
ago, by:
commit 2925f3b7f7738f85aabef4e8fe02f257fce0b786
Author: Naohiro Aota <naohiro.aota@wdc.com>
Date: Tue Jul 26 16:57:59 2022 +0900
btrfs/253: skip on zoned mode as we cannot change the chunk size
Which xfstests version do you use? Do you still hit any problems?
Thanks,
Zorro
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] fstests: skip btrfs/253 for zoned devices
2022-12-20 10:13 ` Zorro Lang
@ 2022-12-20 14:48 ` Johannes Thumshirn
0 siblings, 0 replies; 5+ messages in thread
From: Johannes Thumshirn @ 2022-12-20 14:48 UTC (permalink / raw)
To: Zorro Lang; +Cc: linux-btrfs@vger.kernel.org, fstests@vger.kernel.org
On 20.12.22 11:14, Zorro Lang wrote:
> On Tue, Dec 20, 2022 at 09:19:06AM +0000, Johannes Thumshirn wrote:
>> On 28.11.22 13:30, Johannes Thumshirn wrote:
>>> The test-case btrfs/253 tests btrfs' chunk size setting, which is not
>>> available on zoned btrfs, so the test will always fail.
>>>
>>> Skip the test in case of a zoned device.
>>>
>>> Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
>>> ---
>>> tests/btrfs/253 | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/tests/btrfs/253 b/tests/btrfs/253
>>> index fbbb81fae754..99eaee1e7cde 100755
>>> --- a/tests/btrfs/253
>>> +++ b/tests/btrfs/253
>>> @@ -81,6 +81,7 @@ alloc_size() {
>>> _supported_fs btrfs
>>> _require_test
>>> _require_scratch
>>> +_require_non_zoned_device "${SCRATCH_DEV}"
>>>
>>> # Delete log file if it exists.
>>> rm -f "${seqres}.full"
>>
>> Ping?
>
> Do I misunderstand something? I think this issue has been fixed long time
> ago, by:
>
> commit 2925f3b7f7738f85aabef4e8fe02f257fce0b786
> Author: Naohiro Aota <naohiro.aota@wdc.com>
> Date: Tue Jul 26 16:57:59 2022 +0900
>
> btrfs/253: skip on zoned mode as we cannot change the chunk size
>
> Which xfstests version do you use? Do you still hit any problems?
Whoopsie, maybe it's time for a rebase.
My bad sorry.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-12-20 14:49 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-28 12:29 [PATCH] fstests: skip btrfs/253 for zoned devices Johannes Thumshirn
2022-11-28 16:02 ` Josef Bacik
2022-12-20 9:19 ` Johannes Thumshirn
2022-12-20 10:13 ` Zorro Lang
2022-12-20 14:48 ` Johannes Thumshirn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox