From: Josef Bacik <josef@toxicpanda.com>
To: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 0/4] btrfs: delayed_ref parameter cleanup
Date: Mon, 12 Dec 2022 14:05:36 -0500 [thread overview]
Message-ID: <Y5d7gKMAAnQ11kO5@localhost.localdomain> (raw)
In-Reply-To: <cover.1670835448.git.johannes.thumshirn@wdc.com>
On Mon, Dec 12, 2022 at 01:02:45AM -0800, Johannes Thumshirn wrote:
> While looking at the delayed_ref code for the RST series I've discovered, that
> drop_delayed_ref is using a btrfs_trans_handle without even using it. After
> having it removed I've identified more uses of the trans in the callchain that
> are unused after drop_delayed_ref got rid of it.
>
You can add
Reviewed-by: Josef Bacik <josef@toxicpanda.com>
to the series, thanks,
Josef
next prev parent reply other threads:[~2022-12-12 19:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-12 9:02 [PATCH 0/4] btrfs: delayed_ref parameter cleanup Johannes Thumshirn
2022-12-12 9:02 ` [PATCH 1/4] btrfs: drop unused trans parameter of drop_delayed_ref Johannes Thumshirn
2022-12-12 9:21 ` Qu Wenruo
2022-12-12 9:02 ` [PATCH 2/4] btrfs: remove trans parameter of merge_ref Johannes Thumshirn
2022-12-12 9:22 ` Qu Wenruo
2022-12-12 9:02 ` [PATCH 3/4] btrfs: drop trans parameter of insert_delayed_ref Johannes Thumshirn
2022-12-12 9:22 ` Qu Wenruo
2022-12-12 9:02 ` [PATCH 4/4] btrfs: directly pass in fs_info to btrfs_merge_delayed_refs Johannes Thumshirn
2022-12-12 9:25 ` Qu Wenruo
2022-12-12 19:05 ` Josef Bacik [this message]
2022-12-20 9:17 ` [PATCH 0/4] btrfs: delayed_ref parameter cleanup Johannes Thumshirn
2022-12-20 18:33 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5d7gKMAAnQ11kO5@localhost.localdomain \
--to=josef@toxicpanda.com \
--cc=johannes.thumshirn@wdc.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox