[PATCH] kobject: unexport kobject_create() in kobject.h

[PATCH] kobject: unexport kobject_create() in kobject.h

[Qu Wenruo]

The function kobject_create() is only used by one caller,
kobject_create_and_add(), no other driver uses it, nor is exported to
other modules.

However it's still exported in kobject.h, and can sometimes confuse
users of kobject.h.

Since all users should call kobject_create_and_add(), or if extra
attributes are needed, should alloc the memory manually then call
kobject_init_and_add().

Signed-off-by: Qu Wenruo <wqu@suse.com>
---
 include/linux/kobject.h | 1 -
 lib/kobject.c           | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/include/linux/kobject.h b/include/linux/kobject.h
index ea30529fba08..efd56f990a46 100644
--- a/include/linux/kobject.h
+++ b/include/linux/kobject.h
@@ -101,7 +101,6 @@ int kobject_init_and_add(struct kobject *kobj,
 
 extern void kobject_del(struct kobject *kobj);
 
-extern struct kobject * __must_check kobject_create(void);
 extern struct kobject * __must_check kobject_create_and_add(const char *name,
 						struct kobject *parent);
 
diff --git a/lib/kobject.c b/lib/kobject.c
index ea53b30cf483..4a56f519139d 100644
--- a/lib/kobject.c
+++ b/lib/kobject.c
@@ -777,7 +777,7 @@ static struct kobj_type dynamic_kobj_ktype = {
  * call to kobject_put() and not kfree(), as kobject_init() has
  * already been called on this structure.
  */
-struct kobject *kobject_create(void)
+static struct kobject *kobject_create(void)
 {
 	struct kobject *kobj;
 
-- 
2.33.0

Re: [PATCH] kobject: unexport kobject_create() in kobject.h

[Greg KH]

On Tue, Aug 31, 2021 at 05:30:44PM +0800, Qu Wenruo wrote:
> The function kobject_create() is only used by one caller,
> kobject_create_and_add(), no other driver uses it, nor is exported to
> other modules.
> 
> However it's still exported in kobject.h, and can sometimes confuse
> users of kobject.h.
> 
> Since all users should call kobject_create_and_add(), or if extra
> attributes are needed, should alloc the memory manually then call
> kobject_init_and_add().
> 
> Signed-off-by: Qu Wenruo <wqu@suse.com>
> ---
>  include/linux/kobject.h | 1 -
>  lib/kobject.c           | 2 +-
>  2 files changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/include/linux/kobject.h b/include/linux/kobject.h
> index ea30529fba08..efd56f990a46 100644
> --- a/include/linux/kobject.h
> +++ b/include/linux/kobject.h
> @@ -101,7 +101,6 @@ int kobject_init_and_add(struct kobject *kobj,
>  
>  extern void kobject_del(struct kobject *kobj);
>  
> -extern struct kobject * __must_check kobject_create(void);
>  extern struct kobject * __must_check kobject_create_and_add(const char *name,
>  						struct kobject *parent);
>  
> diff --git a/lib/kobject.c b/lib/kobject.c
> index ea53b30cf483..4a56f519139d 100644
> --- a/lib/kobject.c
> +++ b/lib/kobject.c
> @@ -777,7 +777,7 @@ static struct kobj_type dynamic_kobj_ktype = {
>   * call to kobject_put() and not kfree(), as kobject_init() has
>   * already been called on this structure.
>   */
> -struct kobject *kobject_create(void)
> +static struct kobject *kobject_create(void)
>  {
>  	struct kobject *kobj;
>  
> -- 
> 2.33.0
> 


Hi,

This is the friendly semi-automated patch-bot of Greg Kroah-Hartman.
You have sent him a patch that has triggered this response.

Right now, the development tree you have sent a patch for is "closed"
due to the timing of the merge window.  Don't worry, the patch(es) you
have sent are not lost, and will be looked at after the merge window is
over (after the -rc1 kernel is released by Linus).

So thank you for your patience and your patches will be reviewed at this
later time, you do not have to do anything further, this is just a short
note to let you know the patch status and so you don't worry they didn't
make it through.

thanks,

greg k-h's patch email bot