From: Josef Bacik <josef@toxicpanda.com>
To: Anand Jain <anand.jain@oracle.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 0/2] btrfs-progs: read device fsid from the sysfs
Date: Tue, 19 Oct 2021 10:04:11 -0400 [thread overview]
Message-ID: <YW7QW/RBMWMCnYIo@localhost.localdomain> (raw)
In-Reply-To: <cover.1634598659.git.anand.jain@oracle.com>
On Tue, Oct 19, 2021 at 08:23:43AM +0800, Anand Jain wrote:
> The following test case fails as it trying to read the fsid from the sb
> for a missing device.
>
> $ mkfs.btrfs -f -draid1 -mraid1 $DEV1 $DEV2
> $ btrfstune -S 1 $DEV1
> $ wipefs -a $DEV2
> $ btrfs dev scan --forget
> $ mount -o degraded $DEV1 /btrfs
> $ btrfs device add $DEV3 /btrfs -f
>
> $ btrfs fi us /btrfs
> ERROR: unexpected number of devices: 1 >= 1
> ERROR: if seed device is used, try running this command as root
>
I'd like to see this as either a btrfs-progs test or an fstest. I think I
prefer the fstest because you're adding a sysfs file, so maybe a couple of
tests, one to validate the sysfs file behaves properly, and then one to do this
test as well. Thanks,
Josef
next prev parent reply other threads:[~2021-10-19 14:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 0:23 [PATCH 0/2] btrfs-progs: read device fsid from the sysfs Anand Jain
2021-10-19 0:23 ` [PATCH 1/2] btrfs-progs: prepare helper device_is_seed Anand Jain
2021-10-19 0:23 ` [PATCH 2/2] btrfs-progs: read fsid from the sysfs in device_is_seed Anand Jain
2021-10-19 14:03 ` Josef Bacik
2021-10-20 2:40 ` Anand Jain
2021-10-20 13:47 ` Josef Bacik
2021-10-19 14:04 ` Josef Bacik [this message]
2021-10-20 2:41 ` [PATCH 0/2] btrfs-progs: read device fsid from the sysfs Anand Jain
2022-01-06 0:04 ` Anand Jain
2022-01-11 15:19 ` Nikolay Borisov
2022-01-21 9:29 ` Anand Jain
2022-08-26 0:14 ` Wang Yugui
2022-08-26 10:18 ` Anand Jain
2022-08-27 0:52 ` Wang Yugui
2022-08-10 10:18 ` Qu Wenruo
2022-08-10 11:18 ` Anand Jain
2022-08-10 11:43 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YW7QW/RBMWMCnYIo@localhost.localdomain \
--to=josef@toxicpanda.com \
--cc=anand.jain@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox