From: Josef Bacik <josef@toxicpanda.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH] btrfs: update device path inode time instead of bd_inode
Date: Thu, 14 Oct 2021 11:50:07 -0400 [thread overview]
Message-ID: <YWhRr123vMRtiHF4@localhost.localdomain> (raw)
In-Reply-To: <20211014153347.GA30555@lst.de>
On Thu, Oct 14, 2021 at 05:33:47PM +0200, Christoph Hellwig wrote:
> On Thu, Oct 14, 2021 at 11:17:08AM -0400, Josef Bacik wrote:
> > + now = current_time(d_inode(path.dentry));
> > + generic_update_time(d_inode(path.dentry), &now, S_MTIME | S_CTIME);
>
> This is still broken as it won't call into ->update_time.
> generic_update_time is a helper/default for ->update_time, not something
> for an external caller.
Then we probably need to fix all the people currently calling it. In the
meantime I'll add a helper to use the thing that calls ->update_time instead.
Thanks,
Josef
next prev parent reply other threads:[~2021-10-14 15:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-14 15:17 [PATCH] btrfs: update device path inode time instead of bd_inode Josef Bacik
2021-10-14 15:27 ` David Sterba
2021-10-14 15:33 ` Christoph Hellwig
2021-10-14 15:50 ` Josef Bacik [this message]
2021-10-14 15:53 ` Christoph Hellwig
2021-10-14 16:00 ` Josef Bacik
2021-10-14 16:05 ` Christoph Hellwig
2021-10-14 16:32 ` Josef Bacik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YWhRr123vMRtiHF4@localhost.localdomain \
--to=josef@toxicpanda.com \
--cc=hch@lst.de \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox