From: Josef Bacik <josef@toxicpanda.com>
To: fdmanana@kernel.org
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: fix lost error handling when replaying directory deletes
Date: Thu, 14 Oct 2021 13:23:46 -0400 [thread overview]
Message-ID: <YWhnotaGpI9STlEX@localhost.localdomain> (raw)
In-Reply-To: <d580b8836d741d5f474536ddcb262dcd26de6262.1634228346.git.fdmanana@suse.com>
On Thu, Oct 14, 2021 at 05:26:04PM +0100, fdmanana@kernel.org wrote:
> From: Filipe Manana <fdmanana@suse.com>
>
> At replay_dir_deletes(), if find_dir_range() returns an error we break out
> of the main while loop and then assign a value of 0 (success) to the 'ret'
> variable, resulting in completely ignoring that an error happened. Fix
> that by jumping to the 'out' label when find_dir_range() returns an error
> (negative value).
>
> Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: Josef Bacik <josef@toxicpanda.com>
Thanks,
Josef
next prev parent reply other threads:[~2021-10-14 17:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-14 16:26 [PATCH] btrfs: fix lost error handling when replaying directory deletes fdmanana
2021-10-14 17:23 ` Josef Bacik [this message]
2021-10-15 10:20 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YWhnotaGpI9STlEX@localhost.localdomain \
--to=josef@toxicpanda.com \
--cc=fdmanana@kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox