From: Josef Bacik <josef@toxicpanda.com>
To: Anand Jain <anand.jain@oracle.com>
Cc: dsterba@suse.com, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 0/3 RFC] fsperf: enhancements supporting read policy benchmark
Date: Fri, 12 Nov 2021 09:34:38 -0500 [thread overview]
Message-ID: <YY57fpO88z4I0irk@localhost.localdomain> (raw)
In-Reply-To: <cover.1636678032.git.anand.jain@oracle.com>
On Fri, Nov 12, 2021 at 04:04:36PM +0800, Anand Jain wrote:
> I am sending this early to seek feedback on the best way to benchmark
> more than one read policy.
>
> Patch 1,2 adds helpers to support a new setup.
> Patch 3 adds a generic readonly dio fio benchmark script.
>
This looks reasonable to me, the only thing is I'd want a way for the setup()
part of the test to see that we don't have readpolicy support and simply skip.
Right now there's no mechanism for skipping a test, so add that and it'll be
good.
Also you can just do PR's through github if you want. Thanks,
Josef
next prev parent reply other threads:[~2021-11-12 14:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-12 8:04 [PATCH 0/3 RFC] fsperf: enhancements supporting read policy benchmark Anand Jain
2021-11-12 8:04 ` [PATCH 1/3] fsperf: add a few helper functions Anand Jain
2021-11-12 8:04 ` [PATCH 3/3] fsperf: add a new test case diorandread Anand Jain
2021-11-12 14:34 ` Josef Bacik [this message]
2021-11-15 11:57 ` [PATCH 0/3 RFC] fsperf: enhancements supporting read policy benchmark Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YY57fpO88z4I0irk@localhost.localdomain \
--to=josef@toxicpanda.com \
--cc=anand.jain@oracle.com \
--cc=dsterba@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox