From: Anthony Iliopoulos <ailiop@suse.com>
To: dsterba@suse.cz, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs-progs: enable default zlib compression in btrfs-image
Date: Fri, 18 Feb 2022 20:19:34 +0100 [thread overview]
Message-ID: <Yg/xRrJOXiVunUPk@technoir> (raw)
In-Reply-To: <20220218142533.GV12643@twin.jikos.cz>
On Fri, Feb 18, 2022 at 03:25:33PM +0100, David Sterba wrote:
> On Tue, Feb 15, 2022 at 06:12:13PM +0100, Anthony Iliopoulos wrote:
> > The btrfs-image utility supports zlib compression natively, but it is
> > disabled by default. Enable it at the zlib-defined default compression
> > level (6).
>
> Makes sense to me, I don't think that there's a reason why the dump
> should not be compressed.
>
> However this patch breaks the tests, there are several image dumps
> with crated data for some test cases, so this needs to be adapted first.
That's actually my bad, the tests that do image restoration are failing
because of the options sanity checking as they find compress_level set
during restore. I'll send a v2 to fix this.
prev parent reply other threads:[~2022-02-18 19:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-15 17:12 [PATCH] btrfs-progs: enable default zlib compression in btrfs-image Anthony Iliopoulos
2022-02-18 14:25 ` David Sterba
2022-02-18 19:19 ` Anthony Iliopoulos [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yg/xRrJOXiVunUPk@technoir \
--to=ailiop@suse.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox