Re: [PATCH 3/8] btrfs: check correct bio in finish_compressed_bio_read

[Boris Burkov <boris@bur.io>]

On Thu, Feb 10, 2022 at 05:44:21PM -0500, Josef Bacik wrote:
> Commit c09abff87f90 ("btrfs: cloned bios must not be iterated by
> bio_for_each_segment_all") added ASSERT()'s to make sure we weren't
> calling bio_for_each_segment_all() on a RAID5/6 bio.  However it was
> checking the bio that the compression code passed in, not the
> cb->orig_bio that we actually iterate over, so adjust this ASSERT() to
> check the correct bio.
> 
> Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Reviewed-by: Boris Burkov <boris@bur.io>
> ---
>  fs/btrfs/compression.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/btrfs/compression.c b/fs/btrfs/compression.c
> index 71e5b2e9a1ba..a9d458305a08 100644
> --- a/fs/btrfs/compression.c
> +++ b/fs/btrfs/compression.c
> @@ -259,7 +259,7 @@ static void finish_compressed_bio_read(struct compressed_bio *cb, struct bio *bi
>  		 * We have verified the checksum already, set page checked so
>  		 * the end_io handlers know about it
>  		 */
> -		ASSERT(!bio_flagged(bio, BIO_CLONED));
> +		ASSERT(!bio_flagged(cb->orig_bio, BIO_CLONED));
>  		bio_for_each_segment_all(bvec, cb->orig_bio, iter_all) {
>  			u64 bvec_start = page_offset(bvec->bv_page) +
>  					 bvec->bv_offset;
> -- 
> 2.26.3
>