From: Josef Bacik <josef@toxicpanda.com>
To: dsterba@suse.cz, Johannes Thumshirn <Johannes.Thumshirn@wdc.com>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
"kernel-team@fb.com" <kernel-team@fb.com>
Subject: Re: [PATCH v5 12/19] btrfs-progs: set the number of global roots in the super block
Date: Wed, 9 Mar 2022 16:22:45 -0500 [thread overview]
Message-ID: <YikapaHhZ41AFcmj@localhost.localdomain> (raw)
In-Reply-To: <20220309170553.GY12643@twin.jikos.cz>
On Wed, Mar 09, 2022 at 06:05:53PM +0100, David Sterba wrote:
> On Tue, Mar 08, 2022 at 04:41:44PM +0000, Johannes Thumshirn wrote:
> > On 08/03/2022 17:23, David Sterba wrote:
> > >> u8 metadata_uuid[BTRFS_FSID_SIZE];
> > >>
> > >> + __le64 nr_global_roots;
> > >> +
> > >
> > > Shouldn't this be added after the last item?
> > >
> > >> __le64 block_group_root;
> > >> __le64 block_group_root_generation;
> > >> u8 block_group_root_level;
> > >>
> > >> /* future expansion */
> > >> u8 reserved8[7];
> > >> - __le64 reserved[25];
> > >> + __le64 reserved[24];
> >
> > Or at least inside one of these reserved fields.
>
> OTOH, it's still experimental so we don't expect backward compatibility
> yet so it should be ok to change for now.
I did it this way because it's all still experimental and it makes more sense
for it to be before the new root stuff. Thanks,
Josef
next prev parent reply other threads:[~2022-03-09 21:22 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-07 22:10 [PATCH v5 00/19] btrfs-progs: extent tree v2 support, global roots Josef Bacik
2022-03-07 22:10 ` [PATCH v5 01/19] btrfs-progs: add support for loading the block group root Josef Bacik
2022-03-07 22:10 ` [PATCH v5 02/19] btrfs-progs: add print support for the block group tree Josef Bacik
2022-03-07 22:10 ` [PATCH v5 03/19] btrfs-progs: mkfs: use the btrfs_block_group_root helper Josef Bacik
2022-03-07 22:10 ` [PATCH v5 04/19] btrfs-progs: check-lowmem: " Josef Bacik
2022-03-07 22:10 ` [PATCH v5 05/19] btrfs-progs: handle no bg item in extent tree for free space tree Josef Bacik
2022-03-07 22:10 ` [PATCH v5 06/19] btrfs-progs: mkfs: add support for the block group tree Josef Bacik
2022-03-07 22:10 ` [PATCH v5 07/19] btrfs-progs: check: add block group tree support Josef Bacik
2022-03-07 22:10 ` [PATCH v5 08/19] btrfs-progs: qgroup-verify: scan extents based on block groups Josef Bacik
2022-03-07 22:10 ` [PATCH v5 09/19] btrfs-progs: check: make free space tree validation extent tree v2 aware Josef Bacik
2022-03-07 22:10 ` [PATCH v5 10/19] btrfs-progs: check: add helper to reinit the root based on a key Josef Bacik
2022-03-07 22:10 ` [PATCH v5 11/19] btrfs-progs: check: handle the block group tree properly Josef Bacik
2022-03-07 22:10 ` [PATCH v5 12/19] btrfs-progs: set the number of global roots in the super block Josef Bacik
2022-03-08 16:19 ` David Sterba
2022-03-08 16:41 ` Johannes Thumshirn
2022-03-09 17:05 ` David Sterba
2022-03-09 21:22 ` Josef Bacik [this message]
2022-06-14 12:15 ` Qu Wenruo
2022-06-14 12:47 ` Qu Wenruo
2022-03-07 22:10 ` [PATCH v5 13/19] btrfs-progs: handle the per-block group global root id Josef Bacik
2022-03-07 22:10 ` [PATCH v5 14/19] btrfs-progs: add a btrfs_delete_and_free_root helper Josef Bacik
2022-03-07 22:11 ` [PATCH v5 15/19] btrfs-progs: make btrfs_clear_free_space_tree extent tree v2 aware Josef Bacik
2022-03-07 22:11 ` [PATCH v5 16/19] btrfs-progs: make btrfs_create_tree take a key for the root key Josef Bacik
2022-03-07 22:11 ` [PATCH v5 17/19] btrfs-progs: mkfs: set chunk_item_objectid properly for extent tree v2 Josef Bacik
2022-03-07 22:11 ` [PATCH v5 18/19] btrfs-progs: mkfs: create the global root's Josef Bacik
2022-03-09 18:35 ` David Sterba
2022-03-09 21:21 ` Josef Bacik
2022-03-07 22:11 ` [PATCH v5 19/19] btrfs-progs: check: don't do the root item check for extent tree v2 Josef Bacik
2022-03-09 18:48 ` [PATCH v5 00/19] btrfs-progs: extent tree v2 support, global roots David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YikapaHhZ41AFcmj@localhost.localdomain \
--to=josef@toxicpanda.com \
--cc=Johannes.Thumshirn@wdc.com \
--cc=dsterba@suse.cz \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox