From: Omar Sandoval <osandov@osandov.com>
To: dsterba@suse.cz, linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH 12/12] btrfs: rework inode creation to fix several issues
Date: Wed, 9 Mar 2022 16:18:57 -0800 [thread overview]
Message-ID: <YilD8XM77fCvzvQV@relinquished.localdomain> (raw)
In-Reply-To: <20220307122803.GC12643@twin.jikos.cz>
On Mon, Mar 07, 2022 at 01:28:03PM +0100, David Sterba wrote:
> On Thu, Mar 03, 2022 at 03:19:02PM -0800, Omar Sandoval wrote:
> > From: Omar Sandoval <osandov@fb.com>
>
> > fs/btrfs/acl.c | 36 +--
> > fs/btrfs/ctree.h | 39 ++-
> > fs/btrfs/inode.c | 801 +++++++++++++++++++++++------------------------
> > fs/btrfs/ioctl.c | 174 +++++-----
> > fs/btrfs/props.c | 40 +--
> > fs/btrfs/props.h | 4 -
> > 6 files changed, 508 insertions(+), 586 deletions(-)
>
> Can this be split into more patches? All fine from 1 to 11 and now this,
> it's just too much code change and I don't want to take risk by yet
> another rewrite.
Yeah, at first I thought it'd be too hard to split up the last patch
further, but after you and Sweet Tea both asked me to, I managed to
split out another 4 patches. The end result is almost identical, but
that'll hopefully be easier to review. I'll send it out once xfstests
pass.
next prev parent reply other threads:[~2022-03-10 0:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-03 23:18 [PATCH 00/12] btrfs: inode creation cleanups and fixes Omar Sandoval
2022-03-03 23:18 ` [PATCH 01/12] btrfs: reserve correct number of items for unlink and rmdir Omar Sandoval
2022-03-03 23:18 ` [PATCH 02/12] btrfs: reserve correct number of items for rename Omar Sandoval
2022-03-03 23:18 ` [PATCH 03/12] btrfs: get rid of btrfs_add_nondir() Omar Sandoval
2022-03-03 23:18 ` [PATCH 04/12] btrfs: remove unnecessary btrfs_i_size_write(0) calls Omar Sandoval
2022-03-03 23:18 ` [PATCH 05/12] btrfs: remove unnecessary inode_set_bytes(0) call Omar Sandoval
2022-03-03 23:18 ` [PATCH 06/12] btrfs: remove unnecessary set_nlink() in btrfs_create_subvol_root() Omar Sandoval
2022-03-03 23:18 ` [PATCH 07/12] btrfs: remove unused mnt_userns parameter from __btrfs_set_acl Omar Sandoval
2022-03-03 23:18 ` [PATCH 08/12] btrfs: remove redundant name and name_len parameters to create_subvol Omar Sandoval
2022-03-03 23:18 ` [PATCH 09/12] btrfs: don't pass parent objectid to btrfs_new_inode() explicitly Omar Sandoval
2022-03-03 23:19 ` [PATCH 10/12] btrfs: move btrfs_get_free_objectid() call into btrfs_new_inode() Omar Sandoval
2022-03-03 23:19 ` [PATCH 11/12] btrfs: set inode flags earlier in btrfs_new_inode() Omar Sandoval
2022-03-03 23:19 ` [PATCH 12/12] btrfs: rework inode creation to fix several issues Omar Sandoval
2022-03-07 12:28 ` David Sterba
2022-03-10 0:18 ` Omar Sandoval [this message]
2022-03-07 13:25 ` Sweet Tea Dorminy
2022-03-10 0:20 ` Omar Sandoval
2022-03-07 14:41 ` [PATCH 00/12] btrfs: inode creation cleanups and fixes Sweet Tea Dorminy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YilD8XM77fCvzvQV@relinquished.localdomain \
--to=osandov@osandov.com \
--cc=dsterba@suse.cz \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox