From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1555DC433EF for ; Mon, 11 Apr 2022 12:15:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244170AbiDKMSH (ORCPT ); Mon, 11 Apr 2022 08:18:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51836 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242079AbiDKMSG (ORCPT ); Mon, 11 Apr 2022 08:18:06 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 421A240E65 for ; Mon, 11 Apr 2022 05:15:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=coNkX+YcEaxuES65lg5jr/ydnOTdNOy6GHR1Ly7HbCE=; b=GO85uMlvyKZnU+aAFt6D3Ek8wD VqU0EKzleqH8vIRLeoDewoM0wqlI5JNoBlezRWLNFXQjLOxmB2XxTCYPJqwvSP8tZvGhuweH7Mrz/ tzV4+dBgxpyeUer8UXhznjQTIXDwVEzjIkQTTVDHBBfZgEt7Rhex7T6T78k1AdaCwbituNoQatp6Y hqxXCuXAwHSeTAdNpT5ojlpcDF49xyAy4BMi+F0gnQLUBSIIzclttH8IVU70pPYE2+vZ47o4wlxW2 NXZhZsnif2WjWfGbXNJ+YRvGovXppeIhdhK3lNdLVh6L0416nl93ApW1oXd0MFgMWgXOn02sFwXgn mBFTvpXw==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1ndsxS-008vOK-Mx; Mon, 11 Apr 2022 12:15:50 +0000 Date: Mon, 11 Apr 2022 05:15:50 -0700 From: Christoph Hellwig To: Qu Wenruo Cc: Christoph Hellwig , linux-btrfs@vger.kernel.org, gregkh@linuxfoundation.org Subject: Re: [PATCH 4/4] btrfs: make submit_one_bio() to return void Message-ID: References: <32af072b-ab06-9a89-ad6b-0503106cef94@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <32af072b-ab06-9a89-ad6b-0503106cef94@suse.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Mon, Apr 11, 2022 at 03:20:47PM +0800, Qu Wenruo wrote: > > This really should go into patch 1. > > > Stable tree won't be happy about the size. Really? I've never really seen stable maintainers complain about the size of a patch. Especially if it is almost 100% removal of buggy code.