Re: [RFC ONLY 2/8] btrfs: move btrfs_io_context to volumes.h

Johannes Thumshirn
2022-05-17T08:01:49Z

On 17/05/2022 09:58, Qu Wenruo wrote:
>
>
> On 2022/5/17 15:51, Johannes Thumshirn wrote:
>> On 17/05/2022 09:42, Qu Wenruo wrote:
>>>
>>> On 2022/5/16 22:31, Johannes Thumshirn wrote:
>>>> In preparation for upcoming changes, move 'struct btrfs_io_context' to
>>>> volumes.h, so we can use it outside of volumes.c
>>> In fact I don't think the naming itself (from myself) is that good.
>>>
>>> It maybe a good idea to also do a rename here.
>>>
>>> I have some bad alternatives, but doesn't seem better than the current
>>> generic naming either:
>>>
>>> - btrfs_io_mapping
>>> - btrfs_mapping_context
>>>
>>> Thus I guess the current name is chosen mostly due to lack of better ones.
>>
>> Yep but I'm not any better in naming *cough* btrfs_dp_stripe *cough*. Maybe
>> someone else has an idea.
>
> Forgot to ask in that thread, what does the "dp" naming mean?

Declustered Parity, but that's misleading actually, as RAID1 doesn't do parity
at all (although BTRFS RAID1 is a declustered RAID already).