From: Omar Sandoval <osandov@osandov.com>
To: Andrea Gelmini <andrea.gelmini@gmail.com>
Cc: Christoph Anton Mitterer <calestyo@scientia.org>,
Linux BTRFS <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH 1/2] btrfs: fix space cache corruption and potential double allocations
Date: Wed, 17 Aug 2022 23:40:51 -0700 [thread overview]
Message-ID: <Yv3e8/82qugMFUSJ@relinquished.localdomain> (raw)
In-Reply-To: <CAK-xaQZh4DJf=6oxK2SVuodxE_bhUxEjAJXmYd6KfXGdg_9PEw@mail.gmail.com>
On Thu, Aug 18, 2022 at 08:21:30AM +0200, Andrea Gelmini wrote:
> Il giorno gio 18 ago 2022 alle ore 01:59 Omar Sandoval
> <osandov@osandov.com> ha scritto:
> > From what I've found, it's much more likely to happen if you delete a
> > lot of data soon after boot with space_cache=v2/nospace_cache and
> > discard/discard=sync. I can't say that it'd never happen outside of
> > those conditions, but I suspect that it's much harder to hit otherwise.
>
> Thanks a lot for details.
>
> If "discard" is a necessary condition, does it mean that on HDD we
> don't have the problem?
>
> Do you think is enough for the moment to disable "discard" on nvme/ssd?
Discard is not necessary, but it does make the race window larger. So it
wouldn't hurt to disable it for now.
next prev parent reply other threads:[~2022-08-18 6:40 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-16 23:12 [PATCH 0/2] btrfs: fix filesystem corruption caused by space cache race Omar Sandoval
2022-08-16 23:12 ` [PATCH 1/2] btrfs: fix space cache corruption and potential double allocations Omar Sandoval
2022-08-17 6:21 ` Andrea Gelmini
2022-08-17 16:53 ` Christoph Anton Mitterer
2022-08-17 23:59 ` Omar Sandoval
2022-08-18 0:22 ` Christoph Anton Mitterer
2022-08-18 0:30 ` Omar Sandoval
2022-08-19 0:16 ` Christoph Anton Mitterer
2022-09-01 16:59 ` Christoph Anton Mitterer
2022-09-01 18:18 ` Omar Sandoval
2022-09-01 18:52 ` Holger Hoffstätte
2022-09-01 18:57 ` Omar Sandoval
2022-09-02 15:43 ` Christoph Anton Mitterer
2022-09-02 21:25 ` Christoph Anton Mitterer
2022-08-18 6:21 ` Andrea Gelmini
2022-08-18 6:40 ` Omar Sandoval [this message]
2022-08-17 9:47 ` Filipe Manana
2022-08-17 15:32 ` Omar Sandoval
2022-08-17 15:46 ` Filipe Manana
2022-08-22 13:26 ` David Sterba
2022-08-16 23:12 ` [PATCH 2/2] btrfs: get rid of block group caching progress logic Omar Sandoval
2022-08-17 9:47 ` Filipe Manana
2025-02-20 19:26 ` Alex Lyakas
2025-02-20 21:59 ` Omar Sandoval
2025-02-23 11:31 ` Alex Lyakas
2022-08-22 13:36 ` [PATCH 0/2] btrfs: fix filesystem corruption caused by space cache race David Sterba
2022-08-23 17:27 ` David Sterba
2022-08-23 19:20 ` Christoph Anton Mitterer
2022-08-23 20:29 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yv3e8/82qugMFUSJ@relinquished.localdomain \
--to=osandov@osandov.com \
--cc=andrea.gelmini@gmail.com \
--cc=calestyo@scientia.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox