From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E75E0C54EE9 for ; Mon, 12 Sep 2022 01:37:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229552AbiILBhF (ORCPT ); Sun, 11 Sep 2022 21:37:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229446AbiILBhE (ORCPT ); Sun, 11 Sep 2022 21:37:04 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D836424944; Sun, 11 Sep 2022 18:37:03 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 91862B80B49; Mon, 12 Sep 2022 01:37:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D795EC433C1; Mon, 12 Sep 2022 01:36:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662946621; bh=ktWUICUQqI7TXXDui89I6v4jFPMjjS1A6iIaGOULTbo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=U9sPjmi4Y/7/CrEDLA8NgkkQloydrG58flyH0FudjQa3wrxnW4nWIwlJtHQDLbFNs /sr6U6PuOAWO/Da2yBV38rEbLo78VjzxvBOqXf4k4Q52UV4eUG0kObb29jnR1D0cWZ pawnAVym1DbsjSBd57UGy9S/eZZOUZ9+MIFcI8nLZMQDdEQ14Yq0FFe3qWDDFmie6I qG+8hhGiTsRqPd8sJ3gOZcpuwXCbkgTgtXXhH+pVON10K9DNYWAHV3HR9xzhuV1aT6 oGkMNFVlSnxX6nn9AifSC7Iaa/UUpCBXxLd/GPgRwvo16a/vU4RXPQHvt6P5NRwXs2 LqqtZP0OwxKnA== Date: Sun, 11 Sep 2022 20:36:54 -0500 From: Eric Biggers To: Sweet Tea Dorminy Cc: "Theodore Y. Ts'o" , Jaegeuk Kim , Chris Mason , Josef Bacik , David Sterba , linux-fscrypt@vger.kernel.org, linux-btrfs@vger.kernel.org, kernel-team@fb.com, Omar Sandoval Subject: Re: [PATCH v2 16/20] btrfs: Add new FEATURE_INCOMPAT_FSCRYPT feature flag. Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Mon, Sep 05, 2022 at 08:35:31PM -0400, Sweet Tea Dorminy wrote: > From: Omar Sandoval > > As fscrypt files will be incompatible with older filesystem versions, > new filesystems should be created with an incompat flag for fscrypt. > > Signed-off-by: Omar Sandoval > Signed-off-by: Sweet Tea Dorminy > --- > fs/btrfs/ctree.h | 6 ++++-- > include/uapi/linux/btrfs.h | 1 + > 2 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/fs/btrfs/ctree.h b/fs/btrfs/ctree.h > index 38927a867028..e8d000fcc85d 100644 > --- a/fs/btrfs/ctree.h > +++ b/fs/btrfs/ctree.h > @@ -330,7 +330,8 @@ static_assert(sizeof(struct btrfs_super_block) == BTRFS_SUPER_INFO_SIZE); > BTRFS_FEATURE_INCOMPAT_METADATA_UUID | \ > BTRFS_FEATURE_INCOMPAT_RAID1C34 | \ > BTRFS_FEATURE_INCOMPAT_ZONED | \ > - BTRFS_FEATURE_INCOMPAT_EXTENT_TREE_V2) > + BTRFS_FEATURE_INCOMPAT_EXTENT_TREE_V2 | \ > + BTRFS_FEATURE_INCOMPAT_FSCRYPT) Shouldn't this flag be named "encrypt", to be consistent with the other filesystems? - Eric