From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAE5AC6FA82 for ; Mon, 12 Sep 2022 14:08:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230032AbiILOIs (ORCPT ); Mon, 12 Sep 2022 10:08:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36196 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229924AbiILOIr (ORCPT ); Mon, 12 Sep 2022 10:08:47 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D013E32DBB for ; Mon, 12 Sep 2022 07:08:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=8n+OWHwpsr2zZng9ARhgULB8bh9AFduEKWfcChpG134=; b=T0C4hXL53YL3B0/zrnzQ19dpkI 9KKN2P4XBaJW9Hb4qgozGH/GeoiQx13znfE0+AjStPs62PfUoB0jRyF8GluNEJ/k/HGDDHMiLhCpC 86XEz5iDgA+5h2ifMMCt/E1vOXsDbAnGvherz9L/qySR3sAgDJ1xYGEv1U6ogAFfbTSxeoiPQBPeu kEqTwRoVJbxjnXSSWCOB9zAIZyJSXf/VxzklV7ApwhIzLOG3lq0tHUpwPaGMD/3CDdfvBHZhl2Jat 25VYkUQvEida2jskAivyjEODF+wIdMQxk4LJyv4p1pRDX28i5xZyvoNU/YG7lB90n4rBG1PQcTgfF KpJdG7yg==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1oXk7C-00AVHf-AR; Mon, 12 Sep 2022 14:08:46 +0000 Date: Mon, 12 Sep 2022 07:08:46 -0700 From: Christoph Hellwig To: Josef Bacik Cc: linux-btrfs@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH v2 01/36] btrfs: rename clean_io_failure and remove extraneous args Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Fri, Sep 09, 2022 at 05:53:14PM -0400, Josef Bacik wrote: > This is exported, so rename it to btrfs_clean_io_failure. Additionally > we are passing in the io tree's and such from the inode, so instead of > doing all that simply pass in the inode itself and get all the > components we need directly inside of btrfs_clean_io_failure. So this goes away entirely in my "consolidate btrfs checksumming, repair and bio splitting", not sure if there is much point in renaming it in the meantime.