From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 101D5C6FA89 for ; Wed, 7 Sep 2022 21:00:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229940AbiIGVAm (ORCPT ); Wed, 7 Sep 2022 17:00:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49848 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229517AbiIGVAk (ORCPT ); Wed, 7 Sep 2022 17:00:40 -0400 Received: from mail-qk1-x731.google.com (mail-qk1-x731.google.com [IPv6:2607:f8b0:4864:20::731]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CCA059E888 for ; Wed, 7 Sep 2022 14:00:37 -0700 (PDT) Received: by mail-qk1-x731.google.com with SMTP id c9so11445314qkk.6 for ; Wed, 07 Sep 2022 14:00:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=js7gxeaMZkPigUAoxpkc/AkWfetQpEurT+me6eERS74=; b=HZ6dePp2uUB3a2ltuaZByOW/gWFEqqyEymKacbSD1gtidSR2TfDUbsVqQWMQhcZ3i4 8TMJ4BtSBDpOJPvsfB40L0zDHF/CJLgItwEXSywmocSD0O94H3sewvWSqRFghJkhWCnR xFsd0G3oIqJY+YpR7yx7BXMdgEEcIrfPKWSEA8/BwHgXW2ix+FK7ehoVAi8oPiah89v8 He/D3Ov1GZax2q4ZBB/FEZX+DVDUUGX4C54jrqqEn6qJpZS6mECNkOxrE58OhJJd/bm0 PzrqEE82ILKTKJ1Xeuje+O6SU0zPM7yZ/GOQvE0lNqvZ9xcVDI8aKkIvyIOhFoVMMq7h JeVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=js7gxeaMZkPigUAoxpkc/AkWfetQpEurT+me6eERS74=; b=X3vJKDJEHQSM9NLWZcPBHds95bl14YAb+2DH1OFop9/5kCOKuLowiy1g0OcfSJNXqE VBSRMUEEzTaYf1kStdJwfS0bCIlmStaBefzVbiN0VD2943XAwhzuxizNs/yIyl3R+Nwl 4N45T5ZY5LhWLfOLTsYorziQ7qUEvTyrQIy2v4EWYvxZyYcNqEkyrfo6Pnw43SSlMBu5 goDmYcdYWoiosb1knMdLEpxal8ynRGEySDrE9nIF6KxvUBhHbvxCGtKGwbGTMuG9q5Jj J3kywS9i7xGI9w+fmWuo98m46nbLoZgZlOzbf/mqWDTqvTSARVyBDQzHf0cMakQaxYfg jQUA== X-Gm-Message-State: ACgBeo3xYVTxB7/7UglYHHC0fSa2wYjDoVzqeAqmLypqZ4th0S6dcPwr kLhY1TuF09P3Vu8TJ2aAI4gKvQ== X-Google-Smtp-Source: AA6agR5aCtwbvr/ffq0h/OBDFjVNVKy6G9BY1nph9kc6vKRFCrPA2Vy0Jhcq/aq3ZRstmGtJoso6vA== X-Received: by 2002:a05:620a:1a0c:b0:6bb:a292:bf92 with SMTP id bk12-20020a05620a1a0c00b006bba292bf92mr4281591qkb.90.1662584436756; Wed, 07 Sep 2022 14:00:36 -0700 (PDT) Received: from localhost (cpe-174-109-172-136.nc.res.rr.com. [174.109.172.136]) by smtp.gmail.com with ESMTPSA id hh9-20020a05622a618900b00344576bcfefsm12788112qtb.70.2022.09.07.14.00.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Sep 2022 14:00:36 -0700 (PDT) Date: Wed, 7 Sep 2022 17:00:34 -0400 From: Josef Bacik To: Christoph Hellwig Cc: Chris Mason , David Sterba , Damien Le Moal , Naohiro Aota , Johannes Thumshirn , Qu Wenruo , Jens Axboe , "Darrick J. Wong" , linux-block@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 08/17] btrfs: pass the iomap bio to btrfs_submit_bio Message-ID: References: <20220901074216.1849941-1-hch@lst.de> <20220901074216.1849941-9-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220901074216.1849941-9-hch@lst.de> Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Thu, Sep 01, 2022 at 10:42:07AM +0300, Christoph Hellwig wrote: > Now that btrfs_submit_bio splits the bio when crossing stripe boundaries, > there is no need for the higher level code to do that manually. > > For direct I/O this is really helpful, as btrfs_submit_io can now simply > take the bio allocated by iomap and send it on to btrfs_submit_bio > instead of allocating clones. > > For that to work, the bio embedded into struct btrfs_dio_private needs to > become a full btrfs_bio as expected by btrfs_submit_bio. > > With this change there is a single work item to offload the entire iomap > bio so the heuristics to skip async processing for bios that were split > isn't needed anymore either. > > Signed-off-by: Christoph Hellwig Reviewed-by: Josef Bacik Thanks, Josef