From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5708CC38145 for ; Thu, 8 Sep 2022 13:42:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231636AbiIHNmC (ORCPT ); Thu, 8 Sep 2022 09:42:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59936 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229576AbiIHNmA (ORCPT ); Thu, 8 Sep 2022 09:42:00 -0400 Received: from mail-qk1-x72e.google.com (mail-qk1-x72e.google.com [IPv6:2607:f8b0:4864:20::72e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 08FA8E72D2 for ; Thu, 8 Sep 2022 06:42:00 -0700 (PDT) Received: by mail-qk1-x72e.google.com with SMTP id f4so12877763qkl.7 for ; Thu, 08 Sep 2022 06:41:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=vArWBSM/nIYB9WM/+V9vXBEe1u7QlNsucCYETEZMIl4=; b=3H0LWu9tBE7RU4TEBRMQZrpKn0Eogi/gbLKru1GmfCEN/99xYNyAUUL305YbJj8wsf 35WxKm8cPFGxuC0QJ//0olE8bF8HCaP33XJ2qePfItc8ErJI9abM26RTKSwrmGYuuLfw 8bQ5dSM1p7yVaPhe9IBSiFdltmTrjD+7mZGhKXw7TbCEz9tZ9gPMXLxw105qzv69nhbc VMYMnP1PK0aNlGtYum8+tIec/7U4Fg3Bk+e5ziPJEfJHAKlo3fVGJnBWI657qluAqQHC BdaUl7HYH2qxrBNyEZNvryPXKRUO1eXd7ciZO0VCYd6dP05GYadoC5eioQ8Nab3wWKHQ 4hvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=vArWBSM/nIYB9WM/+V9vXBEe1u7QlNsucCYETEZMIl4=; b=DyGI4rTqWlQQqpblYOsvC/4PYkEYvDvgUd1UQUoeYn8SZw17JjUkhZLMPwAMkiq+U7 jNf4P0wO0qe/KOQg1AqRo12VYHBq+TEZQ7W96PiqCkxrZawlWknbl0S0szc1caRkpIWA pltzOXMG/TWM4r2qZfzuN2KkNqTyDYJkt7D/GDDZkwNLogoUx9PvX/+tDZYeru7hzkJL ffs20cy3H/WDkGhk5IlaTewY3s8WiBzaElQW9K/9qQmoax65CCc/69G6tFP09DhJxI3C UUdBLHnIXQKEzT7lHNU0nB3QrwcT3sWM8NHzMxYCIq29h//6VIDvKELXR4Mf9p2FmPAm tv+Q== X-Gm-Message-State: ACgBeo3YXbhE1CtksQuezjBCIXJ04mIFOdCt72c2ETmJy6TsWbMau7l1 iCQCSrkwYCe4dS3pOfu0Mupneg== X-Google-Smtp-Source: AA6agR6y99PKgF7Urb6nyu+ug+2KCgGfJlr6dZEGrmX50hsIjUYl1d2Gp9FsS4XVZldoWQ7MNhLO/Q== X-Received: by 2002:a05:620a:57b:b0:6bb:f708:589f with SMTP id p27-20020a05620a057b00b006bbf708589fmr6699096qkp.112.1662644518990; Thu, 08 Sep 2022 06:41:58 -0700 (PDT) Received: from localhost (cpe-174-109-172-136.nc.res.rr.com. [174.109.172.136]) by smtp.gmail.com with ESMTPSA id bq38-20020a05620a46a600b006b8f4ade2c9sm17118385qkb.19.2022.09.08.06.41.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Sep 2022 06:41:58 -0700 (PDT) Date: Thu, 8 Sep 2022 09:41:52 -0400 From: Josef Bacik To: Sweet Tea Dorminy Cc: "Theodore Y. Ts'o" , Jaegeuk Kim , Eric Biggers , Chris Mason , David Sterba , linux-fscrypt@vger.kernel.org, linux-btrfs@vger.kernel.org, kernel-team@fb.com, Omar Sandoval Subject: Re: [PATCH v2 01/20] fscrypt: expose fscrypt_nokey_name Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Mon, Sep 05, 2022 at 08:35:16PM -0400, Sweet Tea Dorminy wrote: > From: Omar Sandoval > > btrfs stores its data structures, including filenames in directories, in > its own buffer implementation, struct extent_buffer, composed of > several non-contiguous pages. We could copy filenames into a > temporary buffer and use fscrypt_match_name() against that buffer, such > extensive memcpying would be expensive. Instead, exposing > fscrypt_nokey_name as in this change allows btrfs to recapitulate > fscrypt_match_name() using methods on struct extent_buffer instead of > dealing with a raw byte array. > > Signed-off-by: Omar Sandoval > Signed-off-by: Sweet Tea Dorminy Reviewed-by: Josef Bacik Thanks, Josef