From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 961CFC6FA82 for ; Wed, 14 Sep 2022 11:47:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229943AbiINLrq (ORCPT ); Wed, 14 Sep 2022 07:47:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35074 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229805AbiINLro (ORCPT ); Wed, 14 Sep 2022 07:47:44 -0400 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AAEE67AC25 for ; Wed, 14 Sep 2022 04:47:42 -0700 (PDT) Received: by mail-wm1-x333.google.com with SMTP id n8so3857485wmr.5 for ; Wed, 14 Sep 2022 04:47:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=jkjInFA4v6207rYNR9PZy7GQsLdw9JOAYyp4dYZPwKo=; b=gNw8KIHA1akV3WAIG3mTyAM9FwwfR45IWHpt7v8NJ/D3h8AuPnRAR4Fr9l6bY4Z+l+ yBth3uvMnFhQguK7OFTCFEvob15XvvYYkQE6d5COR/F3dEL9EtIxWGeLd3Ti+huvh2AS UBiZdvfDAe2ffljdOWuaI7kc+tuNrsOiJfuhmKifgcExmxx2CxBo4QEmKguep2CjcgBi Mp80NzZ2QTsl+f2ooHri9mIxl/A9EFiJh010AdjbJ9RG0BFdICtooF0X4b+3YpOiUcxo PiaQDy5iGBG39jXagGb5CLj0tueVl6vvcptlPqe1xaYjbhuQ/GbIW0ZWRwxqmB33Cc8w iz1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=jkjInFA4v6207rYNR9PZy7GQsLdw9JOAYyp4dYZPwKo=; b=1Mee21EIfL8GGEbCncWFCIEJ3YVpCqvRs64YQ216i8z8GkRWiZEgqdTXs36DRVp86U 8KeL5h9w0RjpBXTEWCi6yYkSpb1Fhsqvrda7bJkjPzPYCNPdhCfNANUgG3K+x3xogAnu r+Zqg5sM0ERHAGDGYrkO+WNCcbovMHDkdU2R4BwZlprlGeXDe5qKe9s1Hkl1yf9i4KoT zhpLu31VSoIJoxMin2+uasmlFyhTrjpg5DhpyrE6nsPxrPbtKyyP3EYG+DD8zV1YkGGC t6aM+c66rI18BFV4wtoM8kq+2sQGcdowJLr1IQDRxafAoERBw3PTTGMrpx/dLA116aBF NrxQ== X-Gm-Message-State: ACgBeo2erbZyePUpfyJwCdAcxE03lV5CBhT7n1HuPb4VOZV3v10SG/HF sim5tT7wbXnN45mwJo52WZ0DXw== X-Google-Smtp-Source: AA6agR6aSV3jXyKXuS6Lp8ysxs2qtNOBdPRNKt7wbfiui0ec8Ug1sA6v6mmiNfrSa5l3/MzmVoabgw== X-Received: by 2002:a7b:c84c:0:b0:3b3:3faa:10c3 with SMTP id c12-20020a7bc84c000000b003b33faa10c3mr2800743wml.94.1663156061281; Wed, 14 Sep 2022 04:47:41 -0700 (PDT) Received: from localhost ([185.122.133.20]) by smtp.gmail.com with ESMTPSA id n9-20020a5d6609000000b0021e51c039c5sm13066031wru.80.2022.09.14.04.47.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Sep 2022 04:47:40 -0700 (PDT) Date: Wed, 14 Sep 2022 12:47:40 +0100 From: Johannes Weiner To: Christoph Hellwig Cc: Jens Axboe , Matthew Wilcox , Suren Baghdasaryan , Andrew Morton , Chris Mason , Josef Bacik , David Sterba , Gao Xiang , Chao Yu , linux-block@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-mm@kvack.org Subject: Re: [PATCH 4/5] erofs: add manual PSI accounting for the compressed address space Message-ID: References: <20220910065058.3303831-1-hch@lst.de> <20220910065058.3303831-5-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220910065058.3303831-5-hch@lst.de> Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Sat, Sep 10, 2022 at 08:50:57AM +0200, Christoph Hellwig wrote: > erofs uses an additional address space for compressed data read from disk > in addition to the one directly associated with the inode. Reading into > the lower address space is open coded using add_to_page_cache_lru instead > of using the filemap.c helper for page allocation micro-optimizations, > which means it is not covered by the MM PSI annotations for ->read_folio > and ->readahead, so add manual ones instead. > > Signed-off-by: Christoph Hellwig Acked-by: Johannes Weiner