From: Boris Burkov <boris@bur.io>
To: David Sterba <dsterba@suse.cz>
Cc: linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH] btrfs: send: gate SEND_A_MAX and SEND_C_MAX V3
Date: Tue, 27 Sep 2022 09:02:34 -0700 [thread overview]
Message-ID: <YzMemuUrL/kn3CN0@zen> (raw)
In-Reply-To: <20220927122412.GC13389@twin.jikos.cz>
On Tue, Sep 27, 2022 at 02:24:12PM +0200, David Sterba wrote:
> On Mon, Sep 26, 2022 at 11:15:22AM -0700, Boris Burkov wrote:
> > We haven't finalized send stream v3 yet, so gate setting the max command
> > values behind CONFIG_BTRFS_DEBUG.
> >
> > In my testing, and judging from the code, this is a cosmetic change;
> > verity send commands are still produced (and processed by a compatible
> > btrfs-progs), even with CONFIG_BTRFS_DEBUG=n set.
>
> There must be some misunderstanding and what you implemented is not what
> I had in mind. The debug protection should have been for
> BTRFS_SEND_STREAM_VERSION so we have v3 available for debug builds and
> not otherwise. The version support is not determined by the command
> definitions but by the BTRFS_SEND_STREAM_VERSION macro exported to
> sysfs.
This makes way more sense, thanks! Working on fixing it. I will also
block sending verity based on the proto being >= 3. Sorry for
misunderstanding you in the first place.
prev parent reply other threads:[~2022-09-27 16:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 18:15 [PATCH] btrfs: send: gate SEND_A_MAX and SEND_C_MAX V3 Boris Burkov
2022-09-27 12:24 ` David Sterba
2022-09-27 16:02 ` Boris Burkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzMemuUrL/kn3CN0@zen \
--to=boris@bur.io \
--cc=dsterba@suse.cz \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).