From: Christoph Hellwig <hch@infradead.org>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org, fstests@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
David Disseldorp <ddiss@suse.de>, Zorro Lang <zlang@redhat.com>
Subject: Re: [PATCH v3] fstests: add a generic test to verify direct IO writes with buffer contents change
Date: Wed, 12 Feb 2025 21:49:56 -0800 [thread overview]
Message-ID: <Z62IBLnGOb8C2A1K@infradead.org> (raw)
In-Reply-To: <93410edfde1cb0405c133cca49a8291dcdb90e2e.1739329404.git.wqu@suse.com>
On Wed, Feb 12, 2025 at 01:34:06PM +1030, Qu Wenruo wrote:
> The test case passes on the following fses:
> - ext4
> - xfs
> - btrfs with "nodatasum" mount option
> No data checksum to bother.
>
> - btrfs with default "datasum" mount option and the fix "btrfs: always
> fallback to buffered write if the inode requires checksum"
> This makes btrfs to fallback on buffered IO so the contents won't
> change during writeback of page cache.
>
> And fails on the following fses:
>
> - btrfs with default "datasum" mount option and without the fix
> Expected.
It also fails (as expected) for XFS on a T10-DIF capable device.
The test looks good to me:
Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2025-02-13 5:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-12 3:04 [PATCH v3] fstests: add a generic test to verify direct IO writes with buffer contents change Qu Wenruo
2025-02-12 6:16 ` Darrick J. Wong
2025-02-13 5:49 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z62IBLnGOb8C2A1K@infradead.org \
--to=hch@infradead.org \
--cc=ddiss@suse.de \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox