public inbox for linux-btrfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Dominique Martinet <asmadeus@codewreck.org>
To: Anand Jain <anand.jain@oracle.com>
Cc: linux-btrfs@vger.kernel.org, dsterba@suse.com
Subject: Re: [PATCH] btrfs-progs: resize: remove the misleading warning for the 'max' option
Date: Tue, 18 Mar 2025 18:46:34 +0900	[thread overview]
Message-ID: <Z9lA-mONFDDzqW7P@codewreck.org> (raw)
In-Reply-To: <5c9857b5fbc5b71984594f2f7e6f666cc435118a.1736525474.git.anand.jain@oracle.com>

Anand Jain wrote on Sat, Jan 11, 2025 at 12:11:35AM +0800:
> The disk max size cannot be 256MiB because Btrfs does not allow creating
> a filesystem on disks smaller than 256MiB.
> 
> Remove the incorrect warning for the 'max' option.`
> 
> $ btrfs fi resize max /btrfs
> Resize device id 1 (/dev/sda) from 3.00GiB to max
> WARNING: the new size 0 (0.00B) is < 256MiB, this may be rejected by kernel
> 
> Fixes: 158a25af0d61 ("btrfs-progs: fi resize: warn if new size is < 256M")

Reviewed-by: Dominique Martinet <dominique.martinet@atmark-techno.com>

> -	if (new_size < 256 * SZ_1M)

(I was about to send a patch changing this to `if (new_size != 0 &&
new_size < ...`, but this works too)

Thanks,
-- 
Dominique Martinet | Asmadeus

      parent reply	other threads:[~2025-03-18  9:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-10 16:11 [PATCH] btrfs-progs: resize: remove the misleading warning for the 'max' option Anand Jain
2025-02-03 21:47 ` Anand Jain
2025-03-18  9:46 ` Dominique Martinet [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z9lA-mONFDDzqW7P@codewreck.org \
    --to=asmadeus@codewreck.org \
    --cc=anand.jain@oracle.com \
    --cc=dsterba@suse.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox