From: Christoph Hellwig <hch@infradead.org>
To: Josef Bacik <josef@toxicpanda.com>
Cc: linux-btrfs@vger.kernel.org, fstests@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH] fstests: btrfs/012 don't follow symlinks for populating $SCRATCH_MNT
Date: Sat, 25 Mar 2023 01:18:52 -0700 [thread overview]
Message-ID: <ZB6ubFfBIvFLqs73@infradead.org> (raw)
In-Reply-To: <8d1ac146d94eec8c77f08a6d04cd8d5248dc8dc8.1679688780.git.josef@toxicpanda.com>
On Fri, Mar 24, 2023 at 04:13:19PM -0400, Josef Bacik wrote:
> /lib/modules/$(uname -r)/ can have symlinks to the source tree where the
> kernel was built from, which can have all sorts of stuff, which will
> make the runtime for this test exceedingly long. We're just trying to
> copy some data into our tree to test with, we don't need the entire
> devel tree of whatever we're doing, so use -P to not follow symlinks
> when copying.
Btw, if you're touching this test can you make it _notrun if the
directory doesn't exist? This test always fails for VMs without
any modules.
next prev parent reply other threads:[~2023-03-25 8:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-24 20:13 [PATCH] fstests: btrfs/012 don't follow symlinks for populating $SCRATCH_MNT Josef Bacik
2023-03-24 20:46 ` Roman Mamedov
2023-03-25 4:36 ` Zorro Lang
2023-03-25 8:18 ` Christoph Hellwig [this message]
2023-03-25 17:06 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZB6ubFfBIvFLqs73@infradead.org \
--to=hch@infradead.org \
--cc=fstests@vger.kernel.org \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox