From: Christoph Hellwig <hch@infradead.org>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>
Cc: Christoph Hellwig <hch@infradead.org>, Qu Wenruo <wqu@suse.com>,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v3 02/12] btrfs: introduce a new helper to submit bio for scrub
Date: Sun, 26 Mar 2023 20:36:38 -0700 [thread overview]
Message-ID: <ZCEPRtYWYmTbUfWG@infradead.org> (raw)
In-Reply-To: <1698cfcc-8beb-7211-2e4f-2e8e5e363ece@gmx.com>
On Sat, Mar 25, 2023 at 04:48:40PM +0800, Qu Wenruo wrote:
> > I'd be tempted to just initialize it in the callers given that it's
> > an optional field now. I wonder if the same might also make sense
> > for ->file_offset.
>
> In that case, I'm not sure if adding more and more arguments while almost
> all of them can be optional is a good idea...
>
> Shouldn't we only pass mandatory arguments, then let the caller to populate
> the optional ones?
Yes, that's what I tried to suggest above. Right now inode and
file_offset are mandatory, but with your changes they stop being so,
so we should stop passing them to the allocation helpers.
next prev parent reply other threads:[~2023-03-27 3:36 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 2:12 [PATCH v3 00/12] btrfs: scrub: use a more reader friendly code to implement scrub_simple_mirror() Qu Wenruo
2023-03-20 2:12 ` [PATCH v3 01/12] btrfs: scrub: use dedicated super block verification function to scrub one super block Qu Wenruo
2023-03-21 5:22 ` Anand Jain
2023-03-21 7:25 ` Qu Wenruo
2023-03-21 22:12 ` David Sterba
2023-03-20 2:12 ` [PATCH v3 02/12] btrfs: introduce a new helper to submit bio for scrub Qu Wenruo
2023-03-21 12:02 ` Christoph Hellwig
2023-03-24 9:58 ` Qu Wenruo
2023-03-25 8:09 ` Christoph Hellwig
2023-03-25 8:21 ` Qu Wenruo
2023-03-25 8:31 ` Christoph Hellwig
2023-03-25 8:48 ` Qu Wenruo
2023-03-27 3:36 ` Christoph Hellwig [this message]
2023-03-20 2:12 ` [PATCH v3 03/12] btrfs: introduce a new helper to submit write " Qu Wenruo
2023-03-21 0:14 ` David Sterba
2023-03-21 0:54 ` Qu Wenruo
2023-03-21 1:27 ` David Sterba
2023-03-23 8:48 ` Qu Wenruo
2023-03-20 2:12 ` [PATCH v3 04/12] btrfs: scrub: introduce the structure for new BTRFS_STRIPE_LEN based interface Qu Wenruo
2023-03-21 0:22 ` David Sterba
2023-03-20 2:12 ` [PATCH v3 05/12] btrfs: scrub: introduce a helper to find and fill the sector info for a scrub_stripe Qu Wenruo
2023-03-20 2:12 ` [PATCH v3 06/12] btrfs: scrub: introduce a helper to verify one metadata Qu Wenruo
2023-03-21 0:31 ` David Sterba
2023-03-20 2:12 ` [PATCH v3 07/12] btrfs: scrub: introduce a helper to verify one scrub_stripe Qu Wenruo
2023-03-20 2:12 ` [PATCH v3 08/12] btrfs: scrub: introduce the main read repair worker for scrub_stripe Qu Wenruo
2023-03-20 2:12 ` [PATCH v3 09/12] btrfs: scrub: introduce a writeback helper " Qu Wenruo
2023-03-21 0:43 ` David Sterba
2023-03-20 2:12 ` [PATCH v3 10/12] btrfs: scrub: introduce error reporting functionality " Qu Wenruo
2023-03-20 2:12 ` [PATCH v3 11/12] btrfs: scrub: introduce the helper to queue a stripe for scrub Qu Wenruo
2023-03-20 2:12 ` [PATCH v3 12/12] btrfs: scrub: switch scrub_simple_mirror() to scrub_stripe infrastructure Qu Wenruo
2023-03-21 1:12 ` David Sterba
2023-03-21 0:09 ` [PATCH v3 00/12] btrfs: scrub: use a more reader friendly code to implement scrub_simple_mirror() David Sterba
2023-03-23 6:28 ` Qu Wenruo
2023-03-23 17:51 ` David Sterba
2023-03-24 0:42 ` Qu Wenruo
2023-03-27 23:28 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCEPRtYWYmTbUfWG@infradead.org \
--to=hch@infradead.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo.btrfs@gmx.com \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox