From: Christoph Hellwig <hch@infradead.org>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>
Cc: Christoph Hellwig <hch@infradead.org>, Qu Wenruo <wqu@suse.com>,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v7 02/13] btrfs: introduce a new allocator for scrub specific btrfs_bio
Date: Wed, 29 Mar 2023 16:47:51 -0700 [thread overview]
Message-ID: <ZCTOJ28lA8OR/LFy@infradead.org> (raw)
In-Reply-To: <3289eba8-8492-3c14-6e3c-f6ef7df7cbb1@gmx.com>
On Thu, Mar 30, 2023 at 07:39:43AM +0800, Qu Wenruo wrote:
> But as my usual tendency, it would still be better to have some ASSERT()s to
> make sure we're properly populating @inode for needed call sites.
Well, where would you place them? The only place where we could do it
would be in btrfs_submit_chunk, but without having the inode there is
no way to know if we would have needed one.
> Or we can easily pass some bbio, which should go through csum verification,
> without a valid @inode pointer, and to be treated as NODATACSUM.
> Such problem can be very hard to detect.
That's what we have tests or that check that csums were there and used
to detect and fix problems.
In the new world order I'd rather see bbio->inode != NULL as flag to
run the checksumming and repair infrastructure. Especially as with a
bit more work I'll be able to never set bbio->inode for all metadata
I/O either, and possibly get rid of the btree inode entirely.
next prev parent reply other threads:[~2023-03-29 23:47 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-28 23:56 [PATCH v7 00/13] btrfs: scrub: use a more reader friendly code to implement scrub_simple_mirror() Qu Wenruo
2023-03-28 23:56 ` [PATCH v7 01/13] btrfs: scrub: use dedicated super block verification function to scrub one super block Qu Wenruo
2023-03-29 0:29 ` Anand Jain
2023-03-29 9:20 ` Johannes Thumshirn
2023-03-29 9:53 ` Qu Wenruo
2023-03-29 23:25 ` Christoph Hellwig
2023-03-28 23:56 ` [PATCH v7 02/13] btrfs: introduce a new allocator for scrub specific btrfs_bio Qu Wenruo
2023-03-29 23:32 ` Christoph Hellwig
2023-03-29 23:39 ` Qu Wenruo
2023-03-29 23:47 ` Christoph Hellwig [this message]
2023-03-29 23:51 ` Qu Wenruo
2023-03-29 23:54 ` Christoph Hellwig
2023-03-28 23:56 ` [PATCH v7 03/13] btrfs: introduce a new helper to submit read bio for scrub Qu Wenruo
2023-03-29 23:33 ` Christoph Hellwig
2023-03-29 23:41 ` Qu Wenruo
2023-03-30 6:43 ` Qu Wenruo
2023-03-30 21:50 ` Christoph Hellwig
2023-03-28 23:56 ` [PATCH v7 04/13] btrfs: introduce a new helper to submit write " Qu Wenruo
2023-03-29 23:33 ` Christoph Hellwig
2023-03-30 6:47 ` Qu Wenruo
2023-03-30 22:13 ` Christoph Hellwig
2023-03-31 0:48 ` Qu Wenruo
2023-03-31 0:56 ` Qu Wenruo
2023-03-28 23:56 ` [PATCH v7 05/13] btrfs: scrub: introduce the structure for new BTRFS_STRIPE_LEN based interface Qu Wenruo
2023-03-28 23:56 ` [PATCH v7 06/13] btrfs: scrub: introduce a helper to find and fill the sector info for a scrub_stripe Qu Wenruo
2023-03-28 23:56 ` [PATCH v7 07/13] btrfs: scrub: introduce a helper to verify one metadata Qu Wenruo
2023-03-28 23:56 ` [PATCH v7 08/13] btrfs: scrub: introduce a helper to verify one scrub_stripe Qu Wenruo
2023-03-28 23:56 ` [PATCH v7 09/13] btrfs: scrub: introduce the main read repair worker for scrub_stripe Qu Wenruo
2023-03-28 23:56 ` [PATCH v7 10/13] btrfs: scrub: introduce a writeback helper " Qu Wenruo
2023-03-28 23:56 ` [PATCH v7 11/13] btrfs: scrub: introduce error reporting functionality " Qu Wenruo
2023-03-28 23:56 ` [PATCH v7 12/13] btrfs: scrub: introduce the helper to queue a stripe for scrub Qu Wenruo
2023-03-28 23:56 ` [PATCH v7 13/13] btrfs: scrub: switch scrub_simple_mirror() to scrub_stripe infrastructure Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCTOJ28lA8OR/LFy@infradead.org \
--to=hch@infradead.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo.btrfs@gmx.com \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox