From: Christoph Hellwig <hch@infradead.org>
To: David Sterba <dsterba@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 6/9] btrfs: open code set_extent_bits
Date: Thu, 25 May 2023 02:03:23 -0700 [thread overview]
Message-ID: <ZG8kW2Bfaf7SpDxb@infradead.org> (raw)
In-Reply-To: <016d0db9c71e15f4c39ea866ce82a425db55cf07.1684967923.git.dsterba@suse.com>
On Thu, May 25, 2023 at 01:04:32AM +0200, David Sterba wrote:
> This helper calls set_extent_bit with two more parameters set to default
> values, but otherwise it's purpose is not clear.
... and the naming is confusing as f*%$ given that it doesn't set any
more or less bits thatn set_extent_bit. Good riddance.
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2023-05-25 9:03 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-24 23:04 [PATCH 0/9] Parameter cleanups in extent state helpers David Sterba
2023-05-24 23:04 ` [PATCH 1/9] btrfs: open code set_extent_defrag David Sterba
2023-05-25 8:58 ` Christoph Hellwig
2023-05-25 10:31 ` Qu Wenruo
2023-05-24 23:04 ` [PATCH 2/9] btrfs: open code set_extent_delalloc David Sterba
2023-05-25 8:59 ` Christoph Hellwig
2023-05-25 10:31 ` Qu Wenruo
2023-05-24 23:04 ` [PATCH 3/9] btrfs: open code set_extent_new David Sterba
2023-05-25 8:59 ` Christoph Hellwig
2023-05-25 10:32 ` Qu Wenruo
2023-05-24 23:04 ` [PATCH 4/9] btrfs: open code set_extent_dirty David Sterba
2023-05-25 9:00 ` Christoph Hellwig
2023-05-25 10:33 ` Qu Wenruo
2023-05-24 23:04 ` [PATCH 5/9] btrfs: open code set_extent_bits_nowait David Sterba
2023-05-25 9:02 ` Christoph Hellwig
2023-05-25 22:45 ` David Sterba
2023-05-25 10:33 ` Qu Wenruo
2023-05-24 23:04 ` [PATCH 6/9] btrfs: open code set_extent_bits David Sterba
2023-05-25 9:03 ` Christoph Hellwig [this message]
2023-05-25 10:34 ` Qu Wenruo
2023-05-24 23:04 ` [PATCH 7/9] btrfs: drop NOFAIL from set_extent_bit allocation masks David Sterba
2023-05-25 9:06 ` Christoph Hellwig
2023-05-25 23:25 ` David Sterba
2023-05-25 10:38 ` Qu Wenruo
2023-05-25 23:00 ` David Sterba
2023-05-25 23:26 ` Qu Wenruo
2023-05-24 23:04 ` [PATCH 8/9] btrfs: pass NOWAIT for set/clear extent bits as another bit David Sterba
2023-05-24 23:04 ` [PATCH 9/9] btrfs: drop gfp from parameter extent state helpers David Sterba
2023-05-25 10:25 ` [PATCH 0/9] Parameter cleanups in " Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZG8kW2Bfaf7SpDxb@infradead.org \
--to=hch@infradead.org \
--cc=dsterba@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox