From: Christoph Hellwig <hch@infradead.org>
To: Anand Jain <anand.jain@oracle.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 2/9] btrfs: streamline fsid checks in alloc_fs_devices
Date: Tue, 23 May 2023 09:30:04 -0700 [thread overview]
Message-ID: <ZGzqDIVyRiDT7PSX@infradead.org> (raw)
In-Reply-To: <5113dde5d6f756818885c39bc8ec6f5b8e45ae54.1684826247.git.anand.jain@oracle.com>
On Tue, May 23, 2023 at 06:03:16PM +0800, Anand Jain wrote:
> + ASSERT(!(fsid == NULL && metadata_fsid != NULL));
The more readable way to write this would be;
ASSERT(fsid || !metadata_fsid);
or just throw a
ASSERT(!metadata_fsid);
into the else branch of the if (fsid) check.
> + if (fsid){
missing whitespace before the opening brace.
next prev parent reply other threads:[~2023-05-23 16:30 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-23 10:03 [PATCH 0/9] btrfs: metadata_uuid refactors part1 Anand Jain
2023-05-23 10:03 ` [PATCH 1/9] btrfs: reduce struct btrfs_fs_devices size relocate fsid_change Anand Jain
2023-05-23 16:27 ` Christoph Hellwig
2023-05-23 20:59 ` David Sterba
2023-05-24 5:56 ` Christoph Hellwig
2023-05-24 11:00 ` Anand Jain
2023-05-23 21:31 ` David Sterba
2023-05-24 5:15 ` Anand Jain
2023-05-23 10:03 ` [PATCH 2/9] btrfs: streamline fsid checks in alloc_fs_devices Anand Jain
2023-05-23 16:30 ` Christoph Hellwig [this message]
2023-05-24 8:45 ` Anand Jain
2023-05-23 10:03 ` [PATCH 3/9] btrfs: localise has_metadata_uuid check in alloc_fs_devices args Anand Jain
2023-05-23 10:03 ` [PATCH 4/9] btrfs: add comment about metadata_uuid in btrfs_fs_devices Anand Jain
2023-05-23 10:03 ` [PATCH 5/9] btrfs: simplify check_tree_block_fsid return arg to bool Anand Jain
2023-05-23 10:03 ` [PATCH 6/9] btrfs: refactor with memcmp_fsid_fs_devices helper Anand Jain
2023-05-23 21:23 ` David Sterba
2023-05-24 5:55 ` Anand Jain
2023-05-23 10:03 ` [PATCH 7/9] btrfs: refactor with memcmp_fsid_changed helper Anand Jain
2023-05-23 16:31 ` Christoph Hellwig
2023-05-23 10:03 ` [PATCH 8/9] btrfs: consolidate uuid memcmp in btrfs_validate_super Anand Jain
2023-05-23 10:03 ` [PATCH 9/9] btrfs: fix source code style in find_fsid Anand Jain
2023-05-23 21:29 ` David Sterba
2023-05-24 5:57 ` Anand Jain
2023-05-23 21:33 ` [PATCH 0/9] btrfs: metadata_uuid refactors part1 David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZGzqDIVyRiDT7PSX@infradead.org \
--to=hch@infradead.org \
--cc=anand.jain@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox