From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D23FEB64D9 for ; Mon, 10 Jul 2023 05:29:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229569AbjGJF3C (ORCPT ); Mon, 10 Jul 2023 01:29:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42786 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229450AbjGJF3A (ORCPT ); Mon, 10 Jul 2023 01:29:00 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 11F60A8 for ; Sun, 9 Jul 2023 22:29:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=NwfwhgGcYt1NPNMnai3w13waFo+eOo4lfPEw1qxigmU=; b=ZDaqIYMHNdpTQ6p7tBf8R3mmXf xhPDrFpl42XFkgMoGg4pclYgP2O8WAn/1UF94CB2caMe7Lsr4Yfy+MiXdU9pmYP7JSRNOZY6fsJD5 iXAjjVd9et/eSTPBTnANeh9rKZypMyqVhSF7lGXg8ezTo6/qkKpi2PgqE91tmB9h3rH6/TayTe2Y3 ck+jOrv+DHgBtfhkn6li73RGVMckCp0iLWscdKiHPYwSciKVSF9JnsRruHAyMvgTPX3YODEXEoOPR nEc8OmM0KE7jpAtsCRryqzOjYLVujp+ECvjmWbKByhrk7R2Mr3EK+l8Mi5fTt0wtLS6MnVipBgc6v p8KztFMA==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qIjSD-00ATVr-27; Mon, 10 Jul 2023 05:28:57 +0000 Date: Sun, 9 Jul 2023 22:28:57 -0700 From: Christoph Hellwig To: Qu Wenruo Cc: Christoph Hellwig , Qu Wenruo , linux-btrfs@vger.kernel.org Subject: Re: [PATCH] btrfs: add a debug accounting for eb pages contiguousness Message-ID: References: <20230707084027.91022-1-wqu@suse.com> <6ce97a6a-7068-311e-a63e-c6171321101a@gmx.com> <11964cc8-3415-74d6-a099-23ac80e34932@gmx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <11964cc8-3415-74d6-a099-23ac80e34932@gmx.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Sun, Jul 09, 2023 at 12:44:33PM +0800, Qu Wenruo wrote: > Unfortunately __filemap_get_folio() is still only creating folios using > order 0, under the no_page tag: > > folio = filemap_alloc_folio(gfp, 0); > > So in that case, it's really no difference than find_or_create_page() > for new pages/folios. You're right, willys patches to pass the order haven't actually made it to mainline yet, and I assumed they did. So you'll have to wait another merge window.