From: Christoph Hellwig <hch@infradead.org>
To: Naohiro Aota <naohiro.aota@wdc.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 4/8] btrfs: zoned: reserve zones for an active metadata/system block group
Date: Mon, 24 Jul 2023 08:06:50 -0700 [thread overview]
Message-ID: <ZL6TioS4YxPUJEdg@infradead.org> (raw)
In-Reply-To: <df9fa11d7d8299b04b99d7276a764bfa318f5734.1690171333.git.naohiro.aota@wdc.com>
> +static int reserved_zones(struct btrfs_fs_info *fs_info)
> +{
> + const u64 flags[] = {BTRFS_BLOCK_GROUP_METADATA, BTRFS_BLOCK_GROUP_SYSTEM};
> + int reserved = 0;
> + int i;
> +
> + for (i = 0; i < ARRAY_SIZE(flags); i++) {
> + u64 profile = btrfs_get_alloc_profile(fs_info, flags[i]);
> +
> + switch (profile) {
> + case 0: /* single */
> + reserved += 1;
> + break;
> + case BTRFS_BLOCK_GROUP_DUP:
> + reserved += 2;
> + break;
> + default:
> + ASSERT(0);
> + break;
> + }
> + }
> +
> + return reserved;
> +}
Shouldn't we just store the number of reserved zones in fs_info instead
of recalculating this over and over?
next prev parent reply other threads:[~2023-07-24 15:06 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-24 4:18 [PATCH 0/8] btrfs: zoned: write-time activation of metadata block group Naohiro Aota
2023-07-24 4:18 ` [PATCH 1/8] btrfs: zoned: introduce block_group context for submit_eb_page() Naohiro Aota
2023-07-24 15:00 ` Christoph Hellwig
2023-07-25 5:44 ` Naohiro Aota
2023-07-24 4:18 ` [PATCH 2/8] btrfs: zoned: defer advancing meta_write_pointer Naohiro Aota
2023-07-24 15:04 ` Christoph Hellwig
2023-07-25 8:59 ` Naohiro Aota
2023-07-26 13:06 ` hch
2023-07-24 4:18 ` [PATCH 3/8] btrfs: zoned: update meta_write_pointer on zone finish Naohiro Aota
2023-07-24 15:04 ` Christoph Hellwig
2023-07-25 9:01 ` Naohiro Aota
2023-07-24 4:18 ` [PATCH 4/8] btrfs: zoned: reserve zones for an active metadata/system block group Naohiro Aota
2023-07-24 15:06 ` Christoph Hellwig [this message]
2023-07-25 9:07 ` Naohiro Aota
2023-07-26 13:07 ` hch
2023-07-24 4:18 ` [PATCH 5/8] btrfs: zoned: activate metadata block group on write time Naohiro Aota
2023-07-24 6:24 ` kernel test robot
2023-07-24 7:36 ` kernel test robot
2023-07-24 7:57 ` kernel test robot
2023-07-24 15:12 ` Christoph Hellwig
2023-07-25 9:28 ` Naohiro Aota
2023-07-26 13:10 ` hch
2023-07-24 4:18 ` [PATCH 6/8] btrfs: zoned: no longer count fresh BG region as zone unusable Naohiro Aota
2023-07-24 4:18 ` [PATCH 7/8] btrfs: zoned: don't activate non-DATA BG on allocation Naohiro Aota
2023-07-24 4:18 ` [PATCH 8/8] btrfs: zoned: re-enable metadata over-commit for zoned mode Naohiro Aota
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZL6TioS4YxPUJEdg@infradead.org \
--to=hch@infradead.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=naohiro.aota@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).