Re: [PATCH v2 04/10] btrfs: zoned: defer advancing meta_write_pointer

Christoph Hellwig
2023-08-01T07:58:08Z

On Tue, Aug 01, 2023 at 02:17:13AM +0900, Naohiro Aota wrote:
> if (!lock_extent_buffer_for_io(eb, wbc)) {
> - btrfs_revert_meta_write_pointer(ctx->block_group, eb);
> free_extent_buffer(eb);
> return 0;
> }
> if (ctx->block_group) {
> - /*
> - * Implies write in zoned mode. Mark the last eb in a block group.
> - */
> + /* Implies write in zoned mode. */

.. maybe ->block_group should be named ->zoned_bg to make this
implication very clear to everyone touching the code?

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>