From: Filipe Manana <fdmanana@kernel.org>
To: Naohiro Aota <naohiro.aota@wdc.com>
Cc: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs/220: do not run async discard test on zoned device
Date: Fri, 18 Aug 2023 11:30:53 +0100 [thread overview]
Message-ID: <ZN9IXf/otvhQsxSw@debian0.Home> (raw)
In-Reply-To: <20230818020325.1214715-1-naohiro.aota@wdc.com>
On Fri, Aug 18, 2023 at 11:03:25AM +0900, Naohiro Aota wrote:
> The mount option "discard=async" is not meant to be used on the zoned mode.
> Skip it from the test.
>
> Signed-off-by: Naohiro Aota <naohiro.aota@wdc.com>
Reviewed-by: Filipe Manana <fdmanana@suse.com>
Looks good, thanks.
> ---
> tests/btrfs/220 | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tests/btrfs/220 b/tests/btrfs/220
> index 30ca06f6038d..b092f40bc1e0 100755
> --- a/tests/btrfs/220
> +++ b/tests/btrfs/220
> @@ -279,7 +279,9 @@ test_revertible_options()
> test_should_fail "discard=invalid"
> if [ "$enable_discard_sync" = true ]; then
> test_roundtrip_mount "discard" "discard" "discard=sync" "discard"
> - test_roundtrip_mount "discard=async" "discard=async" "discard=sync" "discard"
> + if ! _scratch_btrfs_is_zoned; then
> + test_roundtrip_mount "discard=async" "discard=async" "discard=sync" "discard"
> + fi
> test_roundtrip_mount "discard=sync" "discard" "nodiscard" "$DEFAULT_NODISCARD_OPTS"
> else
> test_roundtrip_mount "discard" "discard" "discard" "discard"
> --
> 2.41.0
>
prev parent reply other threads:[~2023-08-18 10:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-18 2:03 [PATCH] btrfs/220: do not run async discard test on zoned device Naohiro Aota
2023-08-18 10:30 ` Filipe Manana [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZN9IXf/otvhQsxSw@debian0.Home \
--to=fdmanana@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=naohiro.aota@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox