From: Christoph Hellwig <hch@infradead.org>
To: Bernd Schubert <bschubert@ddn.com>
Cc: linux-fsdevel@vger.kernel.org, bernd.schubert@fastmail.fm,
miklos@szeredi.hu, dsingh@ddn.com,
Josef Bacik <josef@toxicpanda.com>,
linux-btrfs@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>
Subject: Re: [PATCH 1/2] fs: Add and export file_needs_remove_privs
Date: Thu, 31 Aug 2023 23:48:50 -0700 [thread overview]
Message-ID: <ZPGJUtkAO1C+d8+y@infradead.org> (raw)
In-Reply-To: <20230830181519.2964941-2-bschubert@ddn.com>
On Wed, Aug 30, 2023 at 08:15:18PM +0200, Bernd Schubert wrote:
> File systems want to hold a shared lock for DIO writes,
> but may need to drop file priveliges - that a requires an
> exclusive lock. The new export function file_needs_remove_privs()
> is added in order to first check if that is needed.
As said last time - the existing file systems with shared locking for
direct I/O just do the much more pessimistic IS_SEC check here. I'd
suggest to just do that for btrfs first step. If we then have numbers
justifying the finer grained check we should update veryone and not
just do it for one place.
next prev parent reply other threads:[~2023-09-01 6:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-30 18:15 [PATCH 0/2] Use exclusive lock for file_remove_privs Bernd Schubert
2023-08-30 18:15 ` [PATCH 1/2] fs: Add and export file_needs_remove_privs Bernd Schubert
2023-09-01 6:48 ` Christoph Hellwig [this message]
2023-08-30 18:15 ` [PATCH 2/2] btrfs: file_remove_privs needs an exclusive lock Bernd Schubert
2023-08-31 7:40 ` [PATCH 0/2] Use exclusive lock for file_remove_privs Christoph Hellwig
2023-08-31 10:17 ` Bernd Schubert
2023-08-31 10:18 ` Mateusz Guzik
2023-08-31 14:41 ` Bernd Schubert
2023-09-01 6:49 ` Christoph Hellwig
2023-09-01 11:38 ` Matthew Wilcox
2023-09-01 11:47 ` Mateusz Guzik
2023-09-06 15:13 ` Matthew Wilcox
-- strict thread matches above, loose matches on Subject: below --
2023-08-31 11:24 [PATCH v2 " Bernd Schubert
2023-08-31 11:24 ` [PATCH 1/2] fs: Add and export file_needs_remove_privs Bernd Schubert
2023-08-31 13:16 ` Christian Brauner
2023-08-31 13:40 ` Christian Brauner
2023-08-31 14:17 ` Bernd Schubert
2023-09-01 12:50 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZPGJUtkAO1C+d8+y@infradead.org \
--to=hch@infradead.org \
--cc=bernd.schubert@fastmail.fm \
--cc=brauner@kernel.org \
--cc=bschubert@ddn.com \
--cc=dsingh@ddn.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox