From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEBB5C0032E for ; Wed, 25 Oct 2023 15:34:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344756AbjJYPea (ORCPT ); Wed, 25 Oct 2023 11:34:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344802AbjJYPea (ORCPT ); Wed, 25 Oct 2023 11:34:30 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B01E184; Wed, 25 Oct 2023 08:34:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=MksVKmxFF/LOSGBS+HFtPGWz3xXVQGzCyxDBQuuQye0=; b=1vvnudHqJnQC2ZRqLZXuUJQKXu MOM8Uvr1em0IyrUx+dBy1/lwTIa9MZGTdxRufefgB4E6yCGyW/HPHa+wchRz8+PxpFgQ4ZhZ4Bxkm sNxNMZV3GLC/UoVraFhcbpAfGALv92E6KKkLZzhR1njbh26PX8oPn9v2suBYfJCmy/ZmDK4m9j6j/ WR4bpU3oa9Y5+g3ezoGqBA6VoLmzmuUKS7pybaevGfvuMOSrvPt2623BgDKuPaRnBnY9FjrXtFzc9 S+stIgS0RMgRTh0JgIvthZypT0KUBtl91ibHKKRwDcony+uM48tXtHqN8w4l54We5+Wzf/SlKddKy NRsqpAtQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qvftl-00CdCL-1L; Wed, 25 Oct 2023 15:34:21 +0000 Date: Wed, 25 Oct 2023 08:34:21 -0700 From: Christoph Hellwig To: Amir Goldstein Cc: Jan Kara , Christian Brauner , Chris Mason , Josef Bacik , David Sterba , linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 0/3] fanotify support for btrfs sub-volumes Message-ID: References: <20231025135048.36153-1-amir73il@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231025135048.36153-1-amir73il@gmail.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Wed, Oct 25, 2023 at 04:50:45PM +0300, Amir Goldstein wrote: > Jan, > > This patch set implements your suggestion [1] for handling fanotify > events for filesystems with non-uniform f_fsid. File systems nust never report non-uniform fsids (or st_dev) for that matter. btrfs is simply broken here and needs to be fixed.