Re: [PATCH block/for-next v2 07/16] bcachefs: use new helper to get inode from block_device

Kent Overstreet
2023-11-27T07:24:18Z

On Mon, Nov 27, 2023 at 04:09:47PM +0900, Damien Le Moal wrote:
> On 11/27/23 15:21, Yu Kuai wrote:
> > From: Yu Kuai <yukuai3@huawei.com>
> >
> > Which is more efficiency, and also prepare to remove the field
> > 'bd_inode' from block_device.
> >
> > Signed-off-by: Yu Kuai <yukuai3@huawei.com>
> > ---
> > fs/bcachefs/util.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fs/bcachefs/util.h b/fs/bcachefs/util.h
> > index 2984b57b2958..fe7ccb3a3517 100644
> > --- a/fs/bcachefs/util.h
> > +++ b/fs/bcachefs/util.h
> > @@ -518,7 +518,7 @@ int bch2_bio_alloc_pages(struct bio *, size_t, gfp_t);
> >
> > static inline sector_t bdev_sectors(struct block_device *bdev)
> > {
> > - return bdev->bd_inode->i_size >> 9;
> > + return bdev_inode(bdev)->i_size >> 9;
>
> shouldn't this use i_size_read() ?
>
> I missed the history with this but why not use bdev_nr_sectors() and delete this
> helper ?

Actually, this helper seems to be dead code.